summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2015-08-18 19:16:26 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2015-08-18 19:22:07 +0200
commit4134f1dafcc981757c40177bb3c5a3a7a144ff30 (patch)
tree36db022beb563b22d36a0e31d1b87bf090efa93f
parent09d14955e436b144bc69b998c172b3ea47683195 (diff)
downloadconntrack-tools-4134f1dafcc981757c40177bb3c5a3a7a144ff30.tar.gz
conntrack-tools-4134f1dafcc981757c40177bb3c5a3a7a144ff30.zip
conntrackd: missing break in expectation message parser function
Fortunately, the TLVs come in order in the message, however, if the order is changed we'll incorrectly set up the expectation. Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r--src/parse.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/parse.c b/src/parse.c
index 3ac4092..919d36c 100644
--- a/src/parse.c
+++ b/src/parse.c
@@ -524,13 +524,15 @@ int msg2exp(struct nf_expect *exp, struct nethdr *net, size_t remain)
attr = NTA_NEXT(attr, len);
continue;
}
- switch(exp_h[attr->nta_attr].exp_attr) {
+ switch (exp_h[attr->nta_attr].exp_attr) {
case ATTR_EXP_MASTER:
exp_h[attr->nta_attr].parse(master, attr->nta_attr,
NTA_DATA(attr));
+ break;
case ATTR_EXP_EXPECTED:
exp_h[attr->nta_attr].parse(expected, attr->nta_attr,
NTA_DATA(attr));
+ break;
case ATTR_EXP_MASK:
exp_h[attr->nta_attr].parse(mask, attr->nta_attr,
NTA_DATA(attr));