summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Jones <pjones@redhat.com>2017-09-27 16:26:38 -0400
committerPeter Jones <pmjones@gmail.com>2018-03-12 16:21:43 -0400
commit66a7b53677e297ac5be83945dd12ac80c947c6b3 (patch)
tree7f2a3b10c3894576d14802a58781433956369c36
parentdb2f5cf15d00d3a2ee672cb662cf64025d588e33 (diff)
downloadefi-boot-shim-66a7b53677e297ac5be83945dd12ac80c947c6b3.tar.gz
efi-boot-shim-66a7b53677e297ac5be83945dd12ac80c947c6b3.zip
shim: check_db_cert_in_ram(): clear openssl errors /before/ returning.
Covscan says: 455 if (IsFound) { 456 tpm_measure_variable(dbname, guid, CertSize, Cert->SignatureData); 457 return DATA_FOUND; CID 182850 (#1 of 1): Structurally dead code (UNREACHABLE)unreachable: This code cannot be reached: drain_openssl_errors();. 458 drain_openssl_errors(); 459 } else { 460 LogError(L"AuthenticodeVerify(): %d\n", IsFound); 461 } And, well... woops. Signed-off-by: Peter Jones <pjones@redhat.com>
-rw-r--r--shim.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/shim.c b/shim.c
index a9a569fd..71fa8b8b 100644
--- a/shim.c
+++ b/shim.c
@@ -450,8 +450,8 @@ static CHECK_STATUS check_db_cert_in_ram(EFI_SIGNATURE_LIST *CertList,
hash, SHA256_DIGEST_SIZE);
if (IsFound) {
tpm_measure_variable(dbname, guid, CertSize, Cert->SignatureData);
- return DATA_FOUND;
drain_openssl_errors();
+ return DATA_FOUND;
} else {
LogError(L"AuthenticodeVerify(): %d\n", IsFound);
}