diff options
| author | Peter Jones <pjones@redhat.com> | 2023-06-07 13:15:49 -0400 |
|---|---|---|
| committer | Steve McIntyre <48764113+steve-mcintyre@users.noreply.github.com> | 2023-10-19 10:28:44 +0100 |
| commit | 66e6579dbf921152f647a0c16da1d3b2f40861ca (patch) | |
| tree | d586662866b05c85265d7210c1fd23bcb20691be | |
| parent | 7ba7440c49d32f911fb9e1c213307947a777085d (diff) | |
| download | efi-boot-shim-66e6579dbf921152f647a0c16da1d3b2f40861ca.tar.gz efi-boot-shim-66e6579dbf921152f647a0c16da1d3b2f40861ca.zip | |
CVE-2023-40546 mok: fix LogError() invocation
On some ARM platform, jlinton noticed that when we fail to set a
variable (because it isn't supported at all, presumably), our error
message has an extra argument that doesn't match the format string.
This patch removes the extra argument.
Resolves: CVE-2023-40546
Signed-off-by: Peter Jones <pjones@redhat.com>
| -rw-r--r-- | mok.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -291,7 +291,7 @@ mirror_one_esl(CHAR16 *name, EFI_GUID *guid, UINT32 attrs, &var, &varsz); if (EFI_ERROR(efi_status) || !var || !varsz) { LogError(L"Couldn't allocate %lu bytes for mok variable \"%s\": %r\n", - varsz, var, efi_status); + varsz, name, efi_status); return efi_status; } @@ -302,7 +302,7 @@ mirror_one_esl(CHAR16 *name, EFI_GUID *guid, UINT32 attrs, FreePool(var); if (EFI_ERROR(efi_status)) { LogError(L"Couldn't create mok variable \"%s\": %r\n", - varsz, var, efi_status); + name, efi_status); return efi_status; } |