diff options
| author | Daniel Axtens <dja@axtens.net> | 2021-09-07 17:14:35 +1000 |
|---|---|---|
| committer | Peter Jones <pjones@redhat.com> | 2021-09-08 12:08:38 -0400 |
| commit | 69b7bbfc955b12698963a331644833d5ce9fc598 (patch) | |
| tree | 5291bda86123926c289394ffd0f68097666dbb79 | |
| parent | 58e8dce449c8b0f1fb36c01de01fe7ed608f44d4 (diff) | |
| download | efi-boot-shim-69b7bbfc955b12698963a331644833d5ce9fc598.tar.gz efi-boot-shim-69b7bbfc955b12698963a331644833d5ce9fc598.zip | |
Specify that the section is ASCII not UTF-8
The SBAT variable is defined as ASCII, but the SBAT section in a binary was defined as UTF-8. These should match.
Use ASCII rather than UTF-8, because naive parsing of UTF-8 could lead to unexpected results. For example the character 'ä' can be encoded as 0xe4 or as 0x61 0x0308, and these should be considered equivalent. The shim is not smart enough to do this. This could lead to missed verifications, if the variable and section use different encodings.
Define everything as ASCII. It's sad not to be able to have 🦀 in our bootloader names, and potentially annoying for vendor names as well, but oh well.
| -rw-r--r-- | SBAT.md | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -364,7 +364,7 @@ Adding a .sbat section containing the SBAT metadata structure to PE images. | vendor_url | url to look stuff up, contact, whatever. The format of this .sbat section is comma separated values, or more -specifically UTF-8 encoded strings. +specifically ASCII encoded strings. ## Example sbat sections |