diff options
| author | Peter Jones <pjones@redhat.com> | 2022-11-17 12:31:31 -0500 |
|---|---|---|
| committer | Jan Setje-Eilers <73182357+jsetje@users.noreply.github.com> | 2023-01-27 10:03:31 -0800 |
| commit | 7c7642530fab73facaf3eac233cfbce29e10b0ef (patch) | |
| tree | 16540bef4f8e1afe6e503082a7612381439b9c53 | |
| parent | 657b2483ca6e9fcf2ad8ac7ee577ff546d24c3aa (diff) | |
| download | efi-boot-shim-7c7642530fab73facaf3eac233cfbce29e10b0ef.tar.gz efi-boot-shim-7c7642530fab73facaf3eac233cfbce29e10b0ef.zip | |
Enable the NX compatibility flag by default.
Currently by default, when we build shim we do not set the PE
NX-compatibility DLL Characteristic flag. This signifies to the
firmware that shim (including the components it loads) is not prepared
for several related firmware changes:
- non-executable stack
- non-executable pages from AllocatePages()/AllocatePool()/etc.
- non-writable 0 page (not strictly related but some firmware will be
transitioning at the same time)
- the need to use the UEFI 2.10 Memory Attribute Protocol to set page
permissions.
This patch changes that default to be enabled by default. Distributors
of shim will need to ensure that either their builds disable this bit
(using "post-process-pe -N"), or that the bootloaders and kernels you
support loading are all compliant with this change. A new make
variable, POST_PROCESS_PE_FLAGS, has been added to simplify doing so.
Signed-off-by: Peter Jones <pjones@redhat.com>
| -rw-r--r-- | BUILDING | 3 | ||||
| -rw-r--r-- | Make.defaults | 2 | ||||
| -rw-r--r-- | Makefile | 2 | ||||
| -rw-r--r-- | post-process-pe.c | 2 |
4 files changed, 7 insertions, 2 deletions
@@ -78,6 +78,9 @@ Variables you could set to customize the build: - OSLABEL This is the label that will be put in BOOT$(EFI_ARCH).CSV for your OS. By default this is the same value as EFIDIR . +- POST_PROCESS_PE_FLAGS + This allows you to add flags to the invocation of "post-process-pe", for + example to disable the NX compatibility flag. Vendor SBAT data: It will sometimes be requested by reviewers that a build includes extra diff --git a/Make.defaults b/Make.defaults index c46164a3..9af89f4e 100644 --- a/Make.defaults +++ b/Make.defaults @@ -139,6 +139,8 @@ CFLAGS = $(FEATUREFLAGS) \ $(INCLUDES) \ $(DEFINES) +POST_PROCESS_PE_FLAGS = + ifneq ($(origin OVERRIDE_SECURITY_POLICY), undefined) DEFINES += -DOVERRIDE_SECURITY_POLICY endif @@ -255,7 +255,7 @@ endif -j .rela* -j .dyn -j .reloc -j .eh_frame \ -j .vendor_cert -j .sbat -j .sbatlevel \ $(FORMAT) $< $@ - ./post-process-pe -vv $@ + ./post-process-pe -vv $(POST_PROCESS_PE_FLAGS) $@ ifneq ($(origin ENABLE_SHIM_HASH),undefined) %.hash : %.efi diff --git a/post-process-pe.c b/post-process-pe.c index de8f4a38..f39fdddf 100644 --- a/post-process-pe.c +++ b/post-process-pe.c @@ -42,7 +42,7 @@ static int verbosity; 0; \ }) -static bool set_nx_compat = false; +static bool set_nx_compat = true; typedef uint8_t UINT8; typedef uint16_t UINT16; |