summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Setje-Eilers <jan.setjeeilers@oracle.com>2021-02-20 16:18:16 -0800
committerPeter Jones <pjones@redhat.com>2021-02-22 11:21:11 -0500
commitb9ca0895a0679d4d3223685d37f0600b82eae49c (patch)
tree907d27326080fc22f3df95c654a41d750d65598a
parent2b829d22cc26d032d8e778080f3294e99567cfc5 (diff)
downloadefi-boot-shim-b9ca0895a0679d4d3223685d37f0600b82eae49c.tar.gz
efi-boot-shim-b9ca0895a0679d4d3223685d37f0600b82eae49c.zip
Drop --set-section-alignment from Makefile since linker ALIGN(4096)
already enforces the alignment, clarify that objcopy only needs to do the alignment in the SBAT spec.
-rw-r--r--Makefile2
-rw-r--r--SBAT.md5
2 files changed, 6 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index 02f380e0..0cd45b91 100644
--- a/Makefile
+++ b/Makefile
@@ -95,7 +95,7 @@ VENDOR_SBATS := $(foreach x,$(wildcard data/sbat.*.csv),$(notdir $(x)))
sbat_data.o : | $(SBATPATH) $(VENDOR_SBATS)
sbat_data.o : /dev/null
$(CC) $(CFLAGS) -x c -c -o $@ $<
- $(OBJCOPY) --set-section-alignment '.sbat=512' --add-section .sbat=$(SBATPATH) $@
+ $(OBJCOPY) --add-section .sbat=$(SBATPATH) $@
$(foreach vs,$(VENDOR_SBATS),$(call add-vendor-sbat,$(vs),$@))
$(SHIMNAME) : $(SHIMSONAME)
diff --git a/SBAT.md b/SBAT.md
index cce34b6b..ce4ef69c 100644
--- a/SBAT.md
+++ b/SBAT.md
@@ -336,6 +336,11 @@ objcopy --set-section-alignment '.sbat=512' --add-section .sbat=sbat.csv foo.efi
```
+Older versions of objcopy(1) do not support --set-section-alignment
+which is required to force the correct alignment expected from a PE
+file. As long as there is another step, later in the build process,
+such as an linker invocation that forces alignment, objcopy(1) does
+not need to align an intermediate file.
#### UEFI SBAT Variable content