diff options
| author | Kees Cook <kees@outflux.net> | 2012-12-03 15:52:48 -0800 |
|---|---|---|
| committer | Peter Jones <pjones@redhat.com> | 2014-04-11 14:41:22 -0400 |
| commit | 5495694c043de510aaf8ff5dcbe17b6547794083 (patch) | |
| tree | b69b9617b5680d8a94d92ff4afbada5710487a3a /PasswordCrypt.c | |
| parent | 06495f692fa748a553ffbde8bfae2974d8c791c0 (diff) | |
| download | efi-boot-shim-5495694c043de510aaf8ff5dcbe17b6547794083.tar.gz efi-boot-shim-5495694c043de510aaf8ff5dcbe17b6547794083.zip | |
additional bounds-checking on section sizes
This adds additional bounds-checking on the section sizes. Also adds
-Wsign-compare to the Makefile and replaces some signed variables with
unsigned counteparts for robustness.
Signed-off-by: Kees Cook <kees@ubuntu.com>
Diffstat (limited to 'PasswordCrypt.c')
| -rw-r--r-- | PasswordCrypt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/PasswordCrypt.c b/PasswordCrypt.c index 8d72a821..e0a82cfd 100644 --- a/PasswordCrypt.c +++ b/PasswordCrypt.c @@ -154,7 +154,7 @@ static EFI_STATUS sha256_crypt (const char *key, UINT32 key_len, CopyMem(cp, tmp_result, cnt); SHA256_Init(&alt_ctx); - for (cnt = 0; cnt < 16 + alt_result[0]; ++cnt) + for (cnt = 0; cnt < 16ul + alt_result[0]; ++cnt) SHA256_Update(&alt_ctx, salt, salt_size); SHA256_Final(tmp_result, &alt_ctx); @@ -242,7 +242,7 @@ static EFI_STATUS sha512_crypt (const char *key, UINT32 key_len, CopyMem(cp, tmp_result, cnt); SHA512_Init(&alt_ctx); - for (cnt = 0; cnt < 16 + alt_result[0]; ++cnt) + for (cnt = 0; cnt < 16ul + alt_result[0]; ++cnt) SHA512_Update(&alt_ctx, salt, salt_size); SHA512_Final(tmp_result, &alt_ctx); |