diff options
| author | Kamil Aronowski <kamil.aronowski@yahoo.com> | 2023-04-12 18:50:12 +0200 |
|---|---|---|
| committer | Peter Jones <pjones@redhat.com> | 2023-06-21 14:19:51 -0400 |
| commit | 549d34691d68518e55c2edd6e759b19de7f8ddef (patch) | |
| tree | 84bfec1f3e6d73869daad14c7a4c01e1a8980848 /include | |
| parent | f7a4338f1b5ef03dca83ce44075e9d6e5897e037 (diff) | |
| download | efi-boot-shim-549d34691d68518e55c2edd6e759b19de7f8ddef.tar.gz efi-boot-shim-549d34691d68518e55c2edd6e759b19de7f8ddef.zip | |
Rename 'msecs' to 'usecs' to avoid potential confusion
The function msleep uses gBS->Stall which waits for a specified number
of microseconds.
Reference: https://edk2-docs.gitbook.io/edk-ii-uefi-driver-writer-s-guide/5_uefi_services/51_services_that_uefi_drivers_commonly_use/517_stall
This reference even mentions an example sleeping for 10 microseconds: // Wait 10 uS. Notice the letter 'u'.
Therefore it's a good idea to call the function 'usleep' rather than
'msleep', so no one confuses it with milliseconds, and to change the
argument name to match as well.
Signed-off-by: Kamil Aronowski <kamil.aronowski@yahoo.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/asm.h | 4 | ||||
| -rw-r--r-- | include/console.h | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/include/asm.h b/include/asm.h index 03b06557..f5118b23 100644 --- a/include/asm.h +++ b/include/asm.h @@ -40,11 +40,11 @@ static inline void wait_for_debug(void) { uint64_t a, b; int x; - extern void msleep(unsigned long msecs); + extern void usleep(unsigned long usecs); a = read_counter(); for (x = 0; x < 1000; x++) { - msleep(1000); + usleep(1000); b = read_counter(); if (a != b) break; diff --git a/include/console.h b/include/console.h index 2a29c2dc..8eb4b47f 100644 --- a/include/console.h +++ b/include/console.h @@ -123,7 +123,7 @@ extern EFI_STATUS print_crypto_errors(EFI_STATUS rc, char *file, const char *fun #define crypterr(rc) print_crypto_errors((rc), __FILE__, __func__, __LINE__) #ifndef SHIM_UNIT_TEST -extern VOID msleep(unsigned long msecs); +extern VOID usleep(unsigned long usecs); #endif /* This is used in various things to determine if we should print to the |