diff options
| author | Peter Jones <pjones@redhat.com> | 2017-10-19 15:02:41 -0400 |
|---|---|---|
| committer | Peter Jones <pmjones@gmail.com> | 2018-03-12 16:21:43 -0400 |
| commit | a55b4d6688879b7dae213bc2b56ce95d4c70d6c4 (patch) | |
| tree | 350b8bf50079f2adf1b09cfdc8a405cd8d70d12a /lib/shell.c | |
| parent | 4816cd7533f7a9921bd945c12a1fcec48d95c2ed (diff) | |
| download | efi-boot-shim-a55b4d6688879b7dae213bc2b56ce95d4c70d6c4.tar.gz efi-boot-shim-a55b4d6688879b7dae213bc2b56ce95d4c70d6c4.zip | |
lib: Use EFI_ERROR() instead of comparing to EFI_SUCCESS everywhere.
Also consistently name our status variable "efi_status" unless there's a
good reason not to, such as already having another one of those.
Signed-off-by: Peter Jones <pjones@redhat.com>
Diffstat (limited to 'lib/shell.c')
| -rw-r--r-- | lib/shell.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/lib/shell.c b/lib/shell.c index 849f2660..224791a0 100644 --- a/lib/shell.c +++ b/lib/shell.c @@ -14,16 +14,17 @@ EFI_STATUS argsplit(EFI_HANDLE image, int *argc, CHAR16*** ARGV) { unsigned int i, count = 1; - EFI_STATUS status; + EFI_STATUS efi_status; EFI_LOADED_IMAGE *info; CHAR16 *start; *argc = 0; - status = uefi_call_wrapper(BS->HandleProtocol, 3, image, &LoadedImageProtocol, (VOID **) &info); - if (EFI_ERROR(status)) { + efi_status = uefi_call_wrapper(BS->HandleProtocol, 3, image, + &LoadedImageProtocol, (VOID **) &info); + if (EFI_ERROR(efi_status)) { Print(L"Failed to get arguments\n"); - return status; + return efi_status; } for (i = 0; i < info->LoadOptionsSize; i += 2) { |