diff options
| author | Vitaly Kuznetsov <vkuznets@redhat.com> | 2023-09-06 13:22:55 +0200 |
|---|---|---|
| committer | Peter Jones <pjones@redhat.com> | 2024-11-12 17:21:31 -0500 |
| commit | 338fded6cf8a4388562a532faba0862a204bc456 (patch) | |
| tree | 8d95a2e147e9c7abad52479957f430acd03f73d7 /shim.c | |
| parent | 47bbb5e6579fb38d6906f259d8d882b677d38758 (diff) | |
| download | efi-boot-shim-338fded6cf8a4388562a532faba0862a204bc456.tar.gz efi-boot-shim-338fded6cf8a4388562a532faba0862a204bc456.zip | |
Null-terminate 'arguments' in fallback
In case CSV entry contains boot argument (e.g. an image to load for shim)
it must be null-terminated. While populate_stanza() makes sure 'arguments'
end with '\0', add_boot_option() doesn't account for it in 'size'
calculations. E.g. for the following CSV entry:
shimx64.efi,6.6.0-0.rc0.20230904git708283abf896.6.fc40.x86_64,\EFI\Linux\5f93b3c9cf1c488a99786fb8e99fb840-6.6.0-0.rc0.20230904git708283abf896.6.fc40.x86_64.efi,Comment
the resulting variable after 'fallback' looks like:
# hexdump /sys/firmware/efi/efivars/Boot0004-8be4df61-93ca-11d2-aa0d-00e098032b8c | tail -3
0000180 0038 0036 005f 0036 0034 002e 0065 0066
0000190 0069
0000192
Add trailing '\0' to 'size' calculations in add_boot_option() when
'arguments' is not empty. The resulting variable looks like:
# hexdump /sys/firmware/efi/efivars/Boot0004-8be4df61-93ca-11d2-aa0d-00e098032b8c | tail -3
0000180 0038 0036 005f 0036 0034 002e 0065 0066
0000190 0069 0000
0000194
and the specified image is loaded by shim without issues.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Diffstat (limited to 'shim.c')
0 files changed, 0 insertions, 0 deletions