diff options
| author | Adam Ierymenko <adam.ierymenko@gmail.com> | 2015-11-30 16:44:32 -0800 |
|---|---|---|
| committer | Adam Ierymenko <adam.ierymenko@gmail.com> | 2015-11-30 16:44:32 -0800 |
| commit | 944fdfb65e260ed58a91097e42747ccb80c06f6f (patch) | |
| tree | c11d6cae84a420a0439e0ea52198d8c83e900fe2 | |
| parent | be44b15eacc7f34365d86e717e847b86000cbec4 (diff) | |
| download | infinitytier-944fdfb65e260ed58a91097e42747ccb80c06f6f.tar.gz infinitytier-944fdfb65e260ed58a91097e42747ccb80c06f6f.zip | |
Low-impact sanity check against GitHub issue #247 -- will likely prevent other weird recursions too.
| -rw-r--r-- | service/OneService.cpp | 22 |
1 files changed, 21 insertions, 1 deletions
diff --git a/service/OneService.cpp b/service/OneService.cpp index 3d027237..33fb26ac 100644 --- a/service/OneService.cpp +++ b/service/OneService.cpp @@ -340,6 +340,26 @@ public: static BackgroundSoftwareUpdateChecker backgroundSoftwareUpdateChecker; #endif // ZT_AUTO_UPDATE +static bool isBlacklistedLocalInterfaceForZeroTierTraffic(const char *ifn) +{ +#if defined(__linux__) || defined(linux) || defined(__LINUX__) || defined(__linux) + if ((ifn[0] == 'l')&&(ifn[1] == 'o')) return true; // loopback + if ((ifn[0] == 'z')&&(ifn[1] == 't')) return true; // sanity check: zt# + if ((ifn[0] == 't')&&(ifn[1] == 'u')&&(ifn[2] == 'n')) return true; // tun# is probably an OpenVPN tunnel or similar + if ((ifn[0] == 't')&&(ifn[1] == 'a')&&(ifn[2] == 'p')) return true; // tap# is probably an OpenVPN tunnel or similar +#endif + +#ifdef __APPLE__ + if ((ifn[0] == 'l')&&(ifn[1] == 'o')) return true; // loopback + if ((ifn[0] == 'z')&&(ifn[1] == 't')) return true; // sanity check: zt# + if ((ifn[0] == 't')&&(ifn[1] == 'u')&&(ifn[2] == 'n')) return true; // tun# is probably an OpenVPN tunnel or similar + if ((ifn[0] == 't')&&(ifn[1] == 'a')&&(ifn[2] == 'p')) return true; // tap# is probably an OpenVPN tunnel or similar + if ((ifn[0] == 'u')&&(ifn[1] == 't')&&(ifn[2] == 'u')&&(ifn[3] == 'n')) return true; // ... as is utun# +#endif + + return false; +} + static std::string _trimString(const std::string &s) { unsigned long end = (unsigned long)s.length(); @@ -753,7 +773,7 @@ public: if ((getifaddrs(&ifatbl) == 0)&&(ifatbl)) { struct ifaddrs *ifa = ifatbl; while (ifa) { - if ((ifa->ifa_name)&&(ifa->ifa_addr)) { + if ((ifa->ifa_name)&&(ifa->ifa_addr)&&(!isBlacklistedLocalInterfaceForZeroTierTraffic(ifa->ifa_name))) { bool isZT = false; for(std::vector<std::string>::const_iterator d(ztDevices.begin());d!=ztDevices.end();++d) { if (*d == ifa->ifa_name) { |