(fixed) test script liblwip.so placement, also streamlined test logic

5 files changed, 13 insertions, 32 deletions

diff --git a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/monitor_dockerfile b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/monitor_dockerfile
index 08f08ae1..e8f803cd 100644
--- a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/monitor_dockerfile
+++ b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/monitor_dockerfile
@@ -4,6 +4,9 @@ MAINTAINER https://www.zerotier.com/
 
 EXPOSE 9993/udp
 
+# Install LWIP library used by service
+ADD liblwip.so /var/lib/zerotier-one/liblwip.so
+
 # Add ZT files
 RUN mkdir -p /var/lib/zerotier-one/networks.d
 ADD monitor_identity.public /var/lib/zerotier-one/identity.public
@@ -14,11 +17,6 @@ ADD *.name /
 ADD zerotier-one /
 ADD zerotier-cli /
 
-# Install LWIP library used by service
-ADD liblwip.so /
-RUN mkdir -p ext/bin/lwip
-RUN cp liblwip.so ext/bin/lwip/liblwip.so
-
 # Start ZeroTier-One
 ADD monitor_entrypoint.sh /monitor_entrypoint.sh
 RUN chmod -v +x /monitor_entrypoint.sh
diff --git a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/monitor_entrypoint.sh b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/monitor_entrypoint.sh
index ec3dd7fa..d617bd4a 100644
--- a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/monitor_entrypoint.sh
+++ b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/monitor_entrypoint.sh
@@ -26,15 +26,7 @@ echo '*** ZeroTier Network Containers Test Monitor'
 chown -R daemon /var/lib/zerotier-one
 chgrp -R daemon /var/lib/zerotier-one
 su daemon -s /bin/bash -c '/zerotier-one -d -U -p9993 >>/tmp/zerotier-one.out 2>&1'
-echo '*** Waiting for initial identity generation...'
-while [ ! -s /var/lib/zerotier-one/identity.secret ]; do
-	sleep 0.2
-done
-echo '*** Waiting for network config...'
 virtip4=""
-while [ ! -s /var/lib/zerotier-one/networks.d/"$nwconf" ]; do
-	sleep 0.2
-done
 while [ -z "$virtip4" ]; do
 	sleep 0.2
 	virtip4=`/zerotier-cli listnetworks | grep -F $nwid | cut -d ' ' -f 9 | sed 's/,/\n/g' | grep -F '.' | cut -d / -f 1`
diff --git a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/netcon_dockerfile b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/netcon_dockerfile
index 95088b53..ddb0a6c4 100644
--- a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/netcon_dockerfile
+++ b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/netcon_dockerfile
@@ -9,6 +9,9 @@ RUN yum clean all
 
 EXPOSE 9993/udp
 
+# Install LWIP library used by service
+ADD liblwip.so /var/lib/zerotier-one/liblwip.so
+
 # Install syscall intercept library
 ADD zerotier-intercept /
 ADD libzerotierintercept.so.1.0 /
@@ -32,10 +35,5 @@ ADD zerotier-cli /
 ADD netcon_entrypoint.sh /netcon_entrypoint.sh
 RUN chmod -v +x /netcon_entrypoint.sh
 
-# Install LWIP library used by service
-ADD liblwip.so /
-RUN mkdir -p ext/bin/lwip
-RUN cp liblwip.so ext/bin/lwip/liblwip.so
-
 # Start ZeroTier-One
 CMD ["./netcon_entrypoint.sh"]
diff --git a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/netcon_entrypoint.sh b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/netcon_entrypoint.sh
index 10a08eb2..a8784d5c 100644
--- a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/netcon_entrypoint.sh
+++ b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/netcon_entrypoint.sh
@@ -21,16 +21,8 @@ tx_md5sumfile="$file_path"tx_"$bigfile_name"_md5sum"$tmp_ext"
 echo '*** ZeroTier Network Containers Test: ' "$test_name"
 chown -R daemon /var/lib/zerotier-one
 chgrp -R daemon /var/lib/zerotier-one
-su daemon -s /bin/bash -c '/zerotier-one -d -U -p9993 >>/tmp/zerotier-one.out 2>&1'
-echo '*** Waiting for initial identity generation...'
-while [ ! -s /var/lib/zerotier-one/identity.secret ]; do
-	sleep 0.2
-done
-echo '*** Waiting for network config...'
+./zerotier-one -d -U -p9993
 virtip4=""
-while [ ! -s /var/lib/zerotier-one/networks.d/"$nwconf" ]; do
-	sleep 0.2
-done
 while [ -z "$virtip4" ]; do
 	sleep 0.2
 	virtip4=`/zerotier-cli listnetworks | grep -F $nwid | cut -d ' ' -f 9 | sed 's/,/\n/g' | grep -F '.' | cut -d / -f 1`
diff --git a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/test.sh b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/two_party_test.sh
index fa8daddd..b054b34b 100755
--- a/netcon/docker-test/sshd/ openssh-server-7.1p1-3.fc23.x86_64/test.sh
+++ b/netcon/docker-test/sshd/openssh-server-7.1p1-3.fc23.x86_64/two_party_test.sh
@@ -31,10 +31,11 @@ rm -f *.conf
 rm -f *.name
 
 # Start netcon container to be tested
-docker run -d -it -v $PWD/../../_results:/opt/results --device=/dev/net/tun "$test_name":latest
-docker run -d -it -v $PWD/../../_results:/opt/results --device=/dev/net/tun "$test_name"_monitor:latest
+test_container=$(docker run -d -it -v $PWD/../../_results:/opt/results --device=/dev/net/tun "$test_name":latest)
+monitor_container=$(docker run -d -it -v $PWD/../../_results:/opt/results --device=/dev/net/tun "$test_name"_monitor:latest)
 
-sleep 45s
+echo "waiting $netcon_test_wait_time for test to complete."
+sleep $netcon_test_wait_time
 docker kill $(docker ps -a -q)
-
-rm -rf ../../_results/*.tmp
\ No newline at end of file
+docker rm $test_container
+docker rm $monitor_container
\ No newline at end of file