diff options
| author | Adam Ierymenko <adam.ierymenko@gmail.com> | 2013-08-30 17:05:43 -0400 |
|---|---|---|
| committer | Adam Ierymenko <adam.ierymenko@gmail.com> | 2013-08-30 17:05:43 -0400 |
| commit | f3ad05347e55de2fd2a500464acde0979df9941f (patch) | |
| tree | 57376b3114e193201dcfe2d08ef2a5bdb693ad30 /node/Filter.cpp | |
| parent | 1a7e303f97507842c1a0bfffb27b76277bd43bab (diff) | |
| download | infinitytier-f3ad05347e55de2fd2a500464acde0979df9941f.tar.gz infinitytier-f3ad05347e55de2fd2a500464acde0979df9941f.zip | |
Improve code security posture by replacing sprintf with a safer function.
Diffstat (limited to 'node/Filter.cpp')
| -rw-r--r-- | node/Filter.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/node/Filter.cpp b/node/Filter.cpp index 75a7036a..6e28b7cd 100644 --- a/node/Filter.cpp +++ b/node/Filter.cpp @@ -186,7 +186,7 @@ bool Filter::Rule::operator()(unsigned int etype,const void *data,unsigned int l break; default: { char foo[128]; - sprintf(foo,"unrecognized IPv6 header type %d",(int)nextHeader); + Utils::snprintf(foo,sizeof(foo),"unrecognized IPv6 header type %d",(int)nextHeader); throw std::invalid_argument(foo); } } @@ -215,11 +215,11 @@ std::string Filter::Rule::toString() const s.push_back('*'); break; case 1: - sprintf(buf,"%u",_etherType.start); + Utils::snprintf(buf,sizeof(buf),"%u",_etherType.start); s.append(buf); break; default: - sprintf(buf,"%u-%u",_etherType.start,_etherType.end); + Utils::snprintf(buf,sizeof(buf),"%u-%u",_etherType.start,_etherType.end); s.append(buf); break; } @@ -229,11 +229,11 @@ std::string Filter::Rule::toString() const s.push_back('*'); break; case 1: - sprintf(buf,"%u",_protocol.start); + Utils::snprintf(buf,sizeof(buf),"%u",_protocol.start); s.append(buf); break; default: - sprintf(buf,"%u-%u",_protocol.start,_protocol.end); + Utils::snprintf(buf,sizeof(buf),"%u-%u",_protocol.start,_protocol.end); s.append(buf); break; } @@ -243,11 +243,11 @@ std::string Filter::Rule::toString() const s.push_back('*'); break; case 1: - sprintf(buf,"%u",_port.start); + Utils::snprintf(buf,sizeof(buf),"%u",_port.start); s.append(buf); break; default: - sprintf(buf,"%u-%u",_port.start,_port.end); + Utils::snprintf(buf,sizeof(buf),"%u-%u",_port.start,_port.end); s.append(buf); break; } @@ -269,7 +269,7 @@ Filter::Filter(const char *s) ++fn; } catch (std::invalid_argument &exc) { char tmp[256]; - sprintf(tmp,"invalid rule at index %u: %s",fn,exc.what()); + Utils::snprintf(tmp,sizeof(tmp),"invalid rule at index %u: %s",fn,exc.what()); throw std::invalid_argument(tmp); } } |