summaryrefslogtreecommitdiff
path: root/osdep/MacEthernetTap.cpp
diff options
context:
space:
mode:
authorAdam Ierymenko <adam.ierymenko@gmail.com>2018-11-13 12:42:03 -0800
committerAdam Ierymenko <adam.ierymenko@gmail.com>2018-11-13 12:42:03 -0800
commit350116c513a8d6ea48842245b1d85287b834fbf5 (patch)
tree7409dce92c22d47e320b5b3c90f69b13965199a7 /osdep/MacEthernetTap.cpp
parent7bde2c089d2f96bee8a856017c7311eedab1a005 (diff)
downloadinfinitytier-350116c513a8d6ea48842245b1d85287b834fbf5.tar.gz
infinitytier-350116c513a8d6ea48842245b1d85287b834fbf5.zip
Stability improvements for Mac virtual Ethernet tap driver.
Diffstat (limited to 'osdep/MacEthernetTap.cpp')
-rw-r--r--osdep/MacEthernetTap.cpp11
1 files changed, 7 insertions, 4 deletions
diff --git a/osdep/MacEthernetTap.cpp b/osdep/MacEthernetTap.cpp
index 92df2f31..1cfb9375 100644
--- a/osdep/MacEthernetTap.cpp
+++ b/osdep/MacEthernetTap.cpp
@@ -147,7 +147,7 @@ MacEthernetTap::MacEthernetTap(
_agentStdin2 = agentStdin[0];
_agentStdout2 = agentStdout[1];
_agentStderr2 = agentStderr[1];
- long apid = (long)vfork();
+ long apid = (long)fork();
if (apid < 0) {
throw std::runtime_error("fork failed");
} else if (apid == 0) {
@@ -155,10 +155,13 @@ MacEthernetTap::MacEthernetTap(
::dup2(agentStdout[1],STDOUT_FILENO);
::dup2(agentStderr[1],STDERR_FILENO);
::close(agentStdin[0]);
+ ::close(agentStdin[1]);
+ ::close(agentStdout[0]);
::close(agentStdout[1]);
+ ::close(agentStderr[0]);
::close(agentStderr[1]);
::execl(agentPath.c_str(),agentPath.c_str(),devnostr,ethaddr,mtustr,metricstr,(char *)0);
- ::exit(-1);
+ ::_exit(-1);
} else {
_agentPid = apid;
}
@@ -356,8 +359,8 @@ void MacEthernetTap::threadMain()
const int nfds = std::max(std::max(_shutdownSignalPipe[0],_agentStdout),_agentStderr) + 1;
long agentReadPtr = 0;
- fcntl(_agentStdout,F_SETFL,O_NONBLOCK);
- fcntl(_agentStderr,F_SETFL,O_NONBLOCK);
+ fcntl(_agentStdout,F_SETFL,fcntl(_agentStdout,F_GETFL)|O_NONBLOCK);
+ fcntl(_agentStderr,F_SETFL,fcntl(_agentStderr,F_GETFL)|O_NONBLOCK);
FD_ZERO(&readfds);
FD_ZERO(&nullfds);