diff options
author | Pablo Neira Ayuso <pablo@netfilter.org> | 2010-04-05 17:36:42 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2010-04-05 17:36:42 +0200 |
commit | 73661922bc3b7ebf1225d8273147ab4a87757008 (patch) | |
tree | f78e7c3fcc01a82f323a7b8a58145de93e5897c3 /src/msg.c | |
parent | 6e64a11b6d146635bd0e02fa8c9160e73f4c48a9 (diff) | |
download | libmnl-73661922bc3b7ebf1225d8273147ab4a87757008.tar.gz libmnl-73661922bc3b7ebf1225d8273147ab4a87757008.zip |
fix warning in compilation due to different signess
msg.c: In function ‘mnl_nlmsg_ok’:
msg.c:136: warning: comparison between signed and unsigned
msg.c:138: warning: comparison between signed and unsigned
attr.c: In function ‘mnl_attr_ok’:
attr.c:79: warning: comparison between signed and unsigned
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/msg.c')
-rw-r--r-- | src/msg.c | 7 |
1 files changed, 5 insertions, 2 deletions
@@ -130,12 +130,15 @@ void *mnl_nlmsg_get_data_offset(const struct nlmsghdr *nlh, int offset) * message has enough room for the netlink message that it stores, ie. this * function can be used to verify that a netlink message is not malformed nor * truncated. + * + * The @len parameter may become negative in malformed messages during message + * iteration, that is why we use a signed integer. */ int mnl_nlmsg_ok(const struct nlmsghdr *nlh, int len) { - return len >= sizeof(struct nlmsghdr) && + return len >= (int)sizeof(struct nlmsghdr) && nlh->nlmsg_len >= sizeof(struct nlmsghdr) && - nlh->nlmsg_len <= len; + (int)nlh->nlmsg_len <= len; } /** |