blob: 55686ba0be09c22eadb43630012bcb7e5c5ee542 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
|
--- a/libtac/include/libtac.h
+++ b/libtac/include/libtac.h
@@ -67,6 +67,7 @@
#endif
#define TAC_PLUS_ATTRIB_MAX_LEN 255
+#define TAC_PLUS_ATTRIB_MAX_CNT 255
struct tac_attrib {
char *attr;
@@ -105,6 +106,7 @@
#define LIBTAC_STATUS_CONN_TIMEOUT -8
#define LIBTAC_STATUS_CONN_ERR -9
#define LIBTAC_STATUS_ATTRIB_TOO_LONG -10
+#define LIBTAC_STATUS_ATTRIB_TOO_MANY -11
/* Runtime flags */
--- a/libtac/lib/attrib.c
+++ b/libtac/lib/attrib.c
@@ -31,6 +31,7 @@
struct tac_attrib *a;
size_t l1 = strlen(name);
size_t l2;
+ unsigned int attr_cnt = 0;
int total_len;
if (l1 > TAC_PLUS_ATTRIB_MAX_LEN-1) { /* take sep into account */
@@ -69,8 +70,17 @@
} else {
/* find the last allocated block */
a = *attr;
- while(a->next != NULL)
+ while(a->next != NULL) {
a = a->next; /* a holds last allocated block */
+ attr_cnt++;
+ }
+
+ if (attr_cnt+1 >= TAC_PLUS_ATTRIB_MAX_CNT) { /* take new attrib into account */
+ TACSYSLOG((LOG_WARNING,\
+ "%s: Maximum number of attributes exceeded, skipping",\
+ __FUNCTION__))
+ return LIBTAC_STATUS_ATTRIB_TOO_MANY;
+ }
a->next = (struct tac_attrib *) xcalloc(1, sizeof(struct tac_attrib));
a = a->next; /* set current block pointer to the new one */
|
