E1 fixup: initialize $version to null; getVersion() throws if unset; use TestDouble in tests

🤖 Generated by [robots](https://vyos.io)

1 files changed, 5 insertions, 1 deletions

diff --git a/src/engine/VyOSElasticModernFulltextStorageEngine.php b/src/engine/VyOSElasticModernFulltextStorageEngine.php
index 60683b1..2570311 100644
--- a/src/engine/VyOSElasticModernFulltextStorageEngine.php
+++ b/src/engine/VyOSElasticModernFulltextStorageEngine.php
@@ -7,7 +7,7 @@
 abstract class VyOSElasticModernFulltextStorageEngine
   extends PhabricatorFulltextStorageEngine {
 
-  private $version;
+  private $version = null;
 
   public function setVersion($version) {
     $version = (int)$version;
@@ -25,6 +25,10 @@ abstract class VyOSElasticModernFulltextStorageEngine
   }
 
   public function getVersion() {
+    if ($this->version === null) {
+      throw new Exception(
+        pht('Version not configured; call setVersion() or setService() first.'));
+    }
     return $this->version;
   }