summaryrefslogtreecommitdiff
path: root/src/__tests__/VyOSElasticModernFulltextStorageEngineTestCase.php
blob: 7e20fdca3b85d83fa986e43da5f93910b21214d8 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
<?php

/**
 * Test-double subclass of the concrete engine used by unit tests.
 * Overrides host-dependent methods so tests run without a real
 * PhabricatorSearchService; no actual Elasticsearch I/O occurs.
 */
final class VyOSElasticModernFulltextStorageEngineTestDouble
  extends VyOSElasticModernFulltextStorageEngine {

  public function reindexAbstractDocument(
    PhabricatorSearchAbstractDocument $doc) {
    // no-op in tests
  }

  public function executeSearch(PhabricatorSavedQuery $query) {
    return array();
  }

  public function indexExists(?VyOSElasticModernHost $host = null) {
    return false;
  }

  public function getIndexStats(?VyOSElasticModernHost $host = null) {
    return array();
  }

}

final class VyOSElasticModernFulltextStorageEngineTestCase
  extends PhutilTestCase {

  private function newEngine() {
    return new VyOSElasticModernFulltextStorageEngineTestDouble();
  }

  public function testSetVersionAcceptsSevenAndAbove() {
    foreach (array(7, 8, 9, 100) as $v) {
      $engine = $this->newEngine();
      $caught = null;
      try {
        $engine->setVersion($v);
      } catch (Exception $e) {
        $caught = $e;
      }
      $this->assertEqual(
        null,
        $caught,
        pht('Expected no exception for version=%d.', $v));
      $this->assertEqual($v, $engine->getVersion());
    }
  }

  public function testSetVersionRejectsBelowSeven() {
    foreach (array(0, 1, 2, 5, 6) as $v) {
      $engine = $this->newEngine();
      $caught = null;
      try {
        $engine->setVersion($v);
      } catch (Exception $e) {
        $caught = $e;
      }
      $this->assertTrue(
        $caught !== null,
        pht('Expected an exception for version=%d.', $v));
    }
  }

  public function testGetDocumentUri() {
    $engine = $this->newEngine()->setVersion(7);
    $uri = $engine->getDocumentUri('TASK', 'PHID-TASK-abc');
    $this->assertEqual('/_doc/PHID-TASK-abc', $uri);
  }

  public function testGetDocumentUriIgnoresType() {
    // The typeless API does not encode the doc type in the URL.
    $engine = $this->newEngine()->setVersion(7);
    $uri_a = $engine->getDocumentUri('TASK', 'PHID-TASK-abc');
    $uri_b = $engine->getDocumentUri('DREV', 'PHID-TASK-abc');
    $this->assertEqual($uri_a, $uri_b);
  }

  public function testGetSearchUri() {
    $engine = $this->newEngine()->setVersion(7);
    $this->assertEqual(
      '/_search',
      $engine->getSearchUri(array('TASK', 'DREV')));
    $this->assertEqual('/_search', $engine->getSearchUri(array('USER')));
    $this->assertEqual('/_search', $engine->getSearchUri(array()));
  }

  public function testBuildTypeFilter() {
    $engine = $this->newEngine()->setVersion(7);
    $filter = $engine->buildTypeFilter(array('TASK', 'DREV'));
    $expected = array(
      'terms' => array(
        'documentType' => array('TASK', 'DREV'),
      ),
    );
    $this->assertEqual($expected, $filter);
  }

  public function testBuildTypeFilterEmpty() {
    // Empty list still produces a filter; the caller is responsible
    // for normalizing "no types specified" to "all indexable types"
    // before calling this method. This matches the bundled engine's
    // pattern (executeSearch() normalizes before URL construction).
    $engine = $this->newEngine()->setVersion(7);
    $filter = $engine->buildTypeFilter(array());
    $this->assertEqual(
      array('terms' => array('documentType' => array())),
      $filter);
  }

  public function testBuildIndexMappingsShape() {
    $engine = $this->newEngine()->setVersion(7);

    $doc_types = array('TASK', 'DREV');
    $fields = array('title', 'body', 'comment');
    $relationships = array('authorPHID', 'projectPHID');
    $mappings = $engine->buildIndexMappings(
      $doc_types, $fields, $relationships, 'text');

    // Single typeless mapping with one 'properties' block.
    $this->assertTrue(isset($mappings['properties']));
    $this->assertFalse(isset($mappings['TASK']));
    $this->assertFalse(isset($mappings['DREV']));

    // All three text fields have the multi-analyzer shape.
    foreach (array('title', 'body', 'comment') as $field) {
      $this->assertTrue(
        isset($mappings['properties'][$field]),
        pht('Field "%s" missing from mappings.', $field));
      $this->assertEqual(
        'text',
        $mappings['properties'][$field]['type'],
        pht('Field "%s" should be type text.', $field));
      $this->assertTrue(
        isset($mappings['properties'][$field]['fields']['raw']),
        pht('Field "%s" missing raw sub-field.', $field));
      $this->assertTrue(
        isset($mappings['properties'][$field]['fields']['keywords']),
        pht('Field "%s" missing keywords sub-field.', $field));
      $this->assertTrue(
        isset($mappings['properties'][$field]['fields']['stems']),
        pht('Field "%s" missing stems sub-field.', $field));
    }

    // Both relationships emit as keyword fields with doc_values:false.
    foreach (array('authorPHID', 'projectPHID') as $rel) {
      $this->assertEqual(
        'keyword',
        $mappings['properties'][$rel]['type'],
        pht('Relationship "%s" should be keyword type.', $rel));
      $this->assertEqual(
        false,
        $mappings['properties'][$rel]['doc_values'],
        pht('Relationship "%s" should have doc_values:false.', $rel));
      $this->assertEqual(
        'date',
        $mappings['properties'][$rel.'_ts']['type'],
        pht('Relationship "%s" missing timestamp field.', $rel));
      // No include_in_all anywhere.
      $this->assertFalse(
        isset($mappings['properties'][$rel]['include_in_all']),
        pht('Relationship "%s" should not have include_in_all.', $rel));
    }

    // documentType is a keyword field inside properties.
    $this->assertEqual(
      'keyword',
      $mappings['properties']['documentType']['type']);

    // Standard date fields present.
    $this->assertEqual(
      'date',
      $mappings['properties']['dateCreated']['type']);
    $this->assertEqual(
      'date',
      $mappings['properties']['lastModified']['type']);
  }

  public function testBuildIndexMappingsRejectsReservedFieldName() {
    $engine = $this->newEngine()->setVersion(7);
    $caught = null;
    try {
      $engine->buildIndexMappings(
        array(), array('documentType'), array(), 'text');
    } catch (Exception $e) {
      $caught = $e;
    }
    $this->assertTrue(
      $caught !== null,
      pht('Expected exception when field name collides with reserved key.'));
  }

  public function testBuildIndexMappingsRejectsReservedRelationshipName() {
    $engine = $this->newEngine()->setVersion(7);
    $caught = null;
    try {
      $engine->buildIndexMappings(
        array(), array(), array('lastModified'), 'text');
    } catch (Exception $e) {
      $caught = $e;
    }
    $this->assertTrue(
      $caught !== null,
      pht('Expected exception when relationship name collides with reserved key.'));
  }

  public function testBuildIndexMappingsRejectsFooTsClash() {
    // A field named "foo_ts" would clash with the timestamp slot auto-generated
    // for a relationship named "foo".
    $engine = $this->newEngine()->setVersion(7);
    $caught = null;
    try {
      $engine->buildIndexMappings(
        array(), array('foo_ts'), array('foo'), 'text');
    } catch (Exception $e) {
      $caught = $e;
    }
    $this->assertTrue(
      $caught !== null,
      pht('Expected exception for field/relationship timestamp-slot collision.'));
  }

  public function testBuildIndexMappingsEmptyInputsYieldStandardFields() {
    $engine = $this->newEngine()->setVersion(7);
    $mappings = $engine->buildIndexMappings(array(), array(), array(), 'text');
    $this->assertTrue(isset($mappings['properties']['documentType']));
    $this->assertTrue(isset($mappings['properties']['dateCreated']));
    $this->assertTrue(isset($mappings['properties']['lastModified']));
    $this->assertEqual(
      'keyword', $mappings['properties']['documentType']['type']);
    $this->assertEqual('date', $mappings['properties']['dateCreated']['type']);
    $this->assertEqual('date', $mappings['properties']['lastModified']['type']);
  }

  public function testEngineIdentifier() {
    $engine = $this->newEngine();
    $this->assertEqual('elasticsearch-modern', $engine->getEngineIdentifier());
  }

  public function testHostType() {
    $engine = $this->newEngine();
    $host = $engine->getHostType();
    $this->assertTrue($host instanceof VyOSElasticModernHost);
  }

  public function testGetTextFieldType() {
    $engine = $this->newEngine()->setVersion(7);
    $this->assertEqual('text', $engine->getTextFieldType());
  }

  public function testGetTimestampField() {
    $engine = $this->newEngine()->setVersion(7);
    $this->assertEqual('lastModified', $engine->getTimestampField());
  }

  public function testBuildSpecTreatsZeroQueryAsSearchTerm() {
    // '0' is falsy in PHP but must be treated as a non-empty search term.
    // strlen('0') == 1, so the query clause should be present and the
    // default date-sorted path should NOT fire.
    $engine = $this->newEngine()->setVersion(7);
    $query = id(new PhabricatorSavedQuery())
      ->setParameter('query', '0');

    $method = new ReflectionMethod($engine, 'buildSpec');
    $method->setAccessible(true);
    $spec = $method->invoke($engine, $query, array('TASK'));

    $this->assertFalse(isset($spec['sort']));
    $this->assertEqual(
      '0',
      idxv(
        $spec,
        array('query', 'bool', 'must', 0, 'simple_query_string', 'query')));
  }

}