T8989: wave4 vyos_command, dict_op refactorT8989_wave4

* T8989: vyos_command module

* T8989: vyos_command module UAT and SIT

* T8989: vyos_command changelog

* T8989: vyos_command linter

* T8989: vyos_config module

* T8989: vyos_config module changelog

* T8989: Wave 4 vyos_config module with integration and unit tests

* T8323: vyos_system module

* T8332: vyos_system SIT and UAT

* T8323: vyos_vlan module

* T8323: vyos_vlan module

* T8323: vyos_vlan module SIT and UAT

* T8323: vyos_system module

* T8989: Wave 4 vyos_vlan reworked with dict_op engine

* T8989: Fix dict_op single-value string list handling, add vyos_system integration tests

* T8989: logging_global refactor

* T8989: migrate ntp_global, logging_global, firewall_global to dict_op engine

* T8989: vyos_nat module for REST API collection

* T8989: vyos_nat module for REST API collection, linter fixes

* T8989: vyos_ha module for REST API collection

* T8989: vyos_ha module for REST API collection

* T8989: vyos_ha module sanity and linter fixes

* T8989: vyos_ha module sanity and linter fixes

* T8989: vyos_ha module linter fixes

* T8989: vyos.rest AI comment fixes

* T8323: vyos_nat AI comment fixes

* T8989 ai fixes

* T8989: vyos_bgp_address_family dict_op

* T8989: vyos_bgp_address_family vyos_bgp_global dict_op

* T8989: dict_op refactor for firewall_*, nat, user

* T8989: dict_op refactor for firewall_*, nat, user

* T8989: dict_op refactor for ntp_global, ha

* T8989: snmp_server dict_op refactor

* T8989: snmp_server dict_op refactor

* T8989: route_map dict_op refactor

12 files changed, 286 insertions, 0 deletions

diff --git a/tests/integration/targets/vyos_nat/aliases b/tests/integration/targets/vyos_nat/aliases
new file mode 100644
index 0000000..cc0afef
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/aliases
@@ -0,0 +1 @@
+network/vyos
diff --git a/tests/integration/targets/vyos_nat/defaults/main.yaml b/tests/integration/targets/vyos_nat/defaults/main.yaml
new file mode 100644
index 0000000..164afea
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/defaults/main.yaml
@@ -0,0 +1,3 @@
+---
+testcase: "[^_].*"
+test_items: []
diff --git a/tests/integration/targets/vyos_nat/tasks/httpapi.yaml b/tests/integration/targets/vyos_nat/tasks/httpapi.yaml
new file mode 100644
index 0000000..014aa9d
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tasks/httpapi.yaml
@@ -0,0 +1,18 @@
+---
+- name: Collect all httpapi test cases
+  ansible.builtin.find:
+    paths: "{{ role_path }}/tests/httpapi"
+    patterns: "*.yaml"
+    excludes: "_*.yaml"
+  register: test_cases
+  delegate_to: localhost
+
+- name: Set test_items
+  ansible.builtin.set_fact:
+    test_items: "{{ test_cases.files | map(attribute='path') | list | sort }}"
+
+- name: Run test case (connection=httpapi)
+  ansible.builtin.include_tasks: "{{ test_case_to_run }}"
+  loop: "{{ test_items }}"
+  loop_control:
+    loop_var: test_case_to_run
diff --git a/tests/integration/targets/vyos_nat/tasks/main.yaml b/tests/integration/targets/vyos_nat/tasks/main.yaml
new file mode 100644
index 0000000..b1f6193
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tasks/main.yaml
@@ -0,0 +1,5 @@
+---
+- name: Run httpapi tests
+  ansible.builtin.include_tasks: httpapi.yaml
+  tags:
+    - httpapi
diff --git a/tests/integration/targets/vyos_nat/tests/httpapi/_populate_config.yaml b/tests/integration/targets/vyos_nat/tests/httpapi/_populate_config.yaml
new file mode 100644
index 0000000..fd543d5
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tests/httpapi/_populate_config.yaml
@@ -0,0 +1,39 @@
+---
+- name: Populate NAT config for testing
+  vyos.rest.vyos_nat:
+    config:
+      nat:
+        source:
+          rule:
+            - id: 100
+              description: "Source rule 100"
+              outbound_interface:
+                name: eth0
+              translation:
+                address: masquerade
+            - id: 101
+              outbound_interface:
+                name: eth1
+              translation:
+                address: masquerade
+        destination:
+          rule:
+            - id: 200
+              protocol: tcp
+              inbound_interface:
+                name: eth0
+              destination:
+                address: 198.51.100.10
+                port: "80"
+              translation:
+                address: 192.168.1.10
+                port: "8080"
+        static:
+          rule:
+            - id: 300
+              inbound_interface: eth0
+              destination:
+                address: 198.51.100.20
+              translation:
+                address: 192.168.1.20
+    state: merged
diff --git a/tests/integration/targets/vyos_nat/tests/httpapi/_remove_config.yaml b/tests/integration/targets/vyos_nat/tests/httpapi/_remove_config.yaml
new file mode 100644
index 0000000..8ee616b
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tests/httpapi/_remove_config.yaml
@@ -0,0 +1,5 @@
+---
+- name: Remove all NAT configuration
+  vyos.rest.vyos_nat:
+    state: deleted
+  ignore_errors: true
diff --git a/tests/integration/targets/vyos_nat/tests/httpapi/deleted.yaml b/tests/integration/targets/vyos_nat/tests/httpapi/deleted.yaml
new file mode 100644
index 0000000..2d0cff5
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tests/httpapi/deleted.yaml
@@ -0,0 +1,36 @@
+---
+- debug:
+    msg: START vyos_nat deleted integration tests on connection={{ ansible_connection }}
+
+- include_tasks: _remove_config.yaml
+- block:
+    - include_tasks: _populate_config.yaml
+
+    - name: Delete all NAT configuration
+      vyos.rest.vyos_nat: &id001
+        state: deleted
+      register: result
+
+    - assert:
+        that:
+          - result.changed == true
+
+    - name: Gather after delete
+      vyos.rest.vyos_nat:
+        state: gathered
+      register: gathered
+
+    - assert:
+        that:
+          - gathered.gathered == {}
+
+    - name: Delete again (IDEMPOTENT)
+      vyos.rest.vyos_nat: *id001
+      register: result
+
+    - assert:
+        that:
+          - result.changed == false
+
+  always:
+    - include_tasks: _remove_config.yaml
diff --git a/tests/integration/targets/vyos_nat/tests/httpapi/gathered.yaml b/tests/integration/targets/vyos_nat/tests/httpapi/gathered.yaml
new file mode 100644
index 0000000..1aca580
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tests/httpapi/gathered.yaml
@@ -0,0 +1,30 @@
+---
+- debug:
+    msg: START vyos_nat gathered integration tests on connection={{ ansible_connection }}
+
+- include_tasks: _remove_config.yaml
+- block:
+    - include_tasks: _populate_config.yaml
+
+    - name: Gather NAT configuration
+      vyos.rest.vyos_nat:
+        state: gathered
+      register: result
+
+    - assert:
+        that:
+          - result.changed == false
+          - "'nat' in result.gathered"
+          - "'source' in result.gathered.nat"
+          - "'destination' in result.gathered.nat"
+          - "'static' in result.gathered.nat"
+          - result.gathered.nat.source.rule | length == 2
+          - result.gathered.nat.source.rule[0].id == 100
+          - result.gathered.nat.source.rule[1].id == 101
+          - result.gathered.nat.destination.rule[0].id == 200
+          - result.gathered.nat.destination.rule[0].protocol == "tcp"
+          - result.gathered.nat.static.rule[0].id == 300
+          - result.gathered.nat.static.rule[0].inbound_interface == "eth0"
+
+  always:
+    - include_tasks: _remove_config.yaml
diff --git a/tests/integration/targets/vyos_nat/tests/httpapi/merged.yaml b/tests/integration/targets/vyos_nat/tests/httpapi/merged.yaml
new file mode 100644
index 0000000..c64fdb8
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tests/httpapi/merged.yaml
@@ -0,0 +1,49 @@
+---
+- debug:
+    msg: START vyos_nat merged integration tests on connection={{ ansible_connection }}
+
+- include_tasks: _remove_config.yaml
+
+- block:
+    - name: Merge NAT configuration
+      vyos.rest.vyos_nat: &id001
+        config:
+          nat:
+            source:
+              rule:
+                - id: 100
+                  outbound_interface:
+                    name: eth0
+                  translation:
+                    address: masquerade
+            destination:
+              rule:
+                - id: 200
+                  protocol: tcp
+                  inbound_interface:
+                    name: eth0
+                  destination:
+                    address: 198.51.100.10
+                    port: "80"
+                  translation:
+                    address: 192.168.1.10
+                    port: "8080"
+        state: merged
+      register: result
+
+    - assert:
+        that:
+          - result.changed == true
+          - result.commands | length > 0
+
+    - name: Merge again (IDEMPOTENT)
+      vyos.rest.vyos_nat: *id001
+      register: result
+
+    - assert:
+        that:
+          - result.changed == false
+          - result.commands == []
+
+  always:
+    - include_tasks: _remove_config.yaml
diff --git a/tests/integration/targets/vyos_nat/tests/httpapi/overridden.yaml b/tests/integration/targets/vyos_nat/tests/httpapi/overridden.yaml
new file mode 100644
index 0000000..d753cc4
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tests/httpapi/overridden.yaml
@@ -0,0 +1,49 @@
+---
+- debug:
+    msg: START vyos_nat overridden integration tests on connection={{ ansible_connection }}
+
+- include_tasks: _remove_config.yaml
+- block:
+    - include_tasks: _populate_config.yaml
+
+    - name: Override - replaces all NAT with only one rule
+      vyos.rest.vyos_nat: &id001
+        config:
+          nat:
+            source:
+              rule:
+                - id: 999
+                  outbound_interface:
+                    name: eth0
+                  translation:
+                    address: masquerade
+        state: overridden
+      register: result
+
+    - assert:
+        that:
+          - result.changed == true
+
+    - name: Gather after override
+      vyos.rest.vyos_nat:
+        state: gathered
+      register: gathered
+
+    - assert:
+        that:
+          - gathered.gathered.nat.source.rule | length == 1
+          - gathered.gathered.nat.source.rule[0].id == 999
+          - "'destination' not in gathered.gathered.nat"
+          - "'static' not in gathered.gathered.nat"
+
+    - name: Override again (IDEMPOTENT)
+      vyos.rest.vyos_nat: *id001
+      register: result
+
+    - assert:
+        that:
+          - result.changed == false
+          - result.commands == []
+
+  always:
+    - include_tasks: _remove_config.yaml
diff --git a/tests/integration/targets/vyos_nat/tests/httpapi/replaced.yaml b/tests/integration/targets/vyos_nat/tests/httpapi/replaced.yaml
new file mode 100644
index 0000000..67a16f7
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/tests/httpapi/replaced.yaml
@@ -0,0 +1,49 @@
+---
+- debug:
+    msg: START vyos_nat replaced integration tests on connection={{ ansible_connection }}
+
+- include_tasks: _remove_config.yaml
+- block:
+    - include_tasks: _populate_config.yaml
+
+    - name: Replace source NAT - removes rule 101, keeps destination and static
+      vyos.rest.vyos_nat: &id001
+        config:
+          nat:
+            source:
+              rule:
+                - id: 100
+                  outbound_interface:
+                    name: eth0
+                  translation:
+                    address: masquerade
+        state: replaced
+      register: result
+
+    - assert:
+        that:
+          - result.changed == true
+
+    - name: Gather after replace
+      vyos.rest.vyos_nat:
+        state: gathered
+      register: gathered
+
+    - assert:
+        that:
+          - gathered.gathered.nat.source.rule | length == 1
+          - gathered.gathered.nat.source.rule[0].id == 100
+          - "'destination' in gathered.gathered.nat"
+          - "'static' in gathered.gathered.nat"
+
+    - name: Replace again (IDEMPOTENT)
+      vyos.rest.vyos_nat: *id001
+      register: result
+
+    - assert:
+        that:
+          - result.changed == false
+          - result.commands == []
+
+  always:
+    - include_tasks: _remove_config.yaml
diff --git a/tests/integration/targets/vyos_nat/vars/main.yaml b/tests/integration/targets/vyos_nat/vars/main.yaml
new file mode 100644
index 0000000..4303881
--- /dev/null
+++ b/tests/integration/targets/vyos_nat/vars/main.yaml
@@ -0,0 +1,2 @@
+---
+# only common vars here