1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
|
# -*- coding: utf-8 -*-
from __future__ import absolute_import, division, print_function
__metaclass__ = type
import json
import os
import unittest
from unittest.mock import MagicMock
from ansible_collections.vyos.rest.plugins.modules.vyos_lag_interfaces import (
_bond_base,
_bond_cmds,
_normalize,
build_commands,
get_running_config,
)
def load_fixture(filename):
fixtures_dir = os.path.join(os.path.dirname(__file__), "..", "fixtures")
path = os.path.join(fixtures_dir, filename)
with open(path) as f:
return json.load(f)
class VyOSModuleTestCase(unittest.TestCase):
def setUp(self):
self.mock_vyos = MagicMock()
self.mock_vyos.get_config = MagicMock(return_value={})
def set_running_config(self, data):
self.mock_vyos.get_config.return_value = data
class TestVyOSLagInterfacesBondBase(unittest.TestCase):
def test_bond_base(self):
self.assertEqual(
_bond_base("bond0"),
["interfaces", "bonding", "bond0"],
)
class TestVyOSLagInterfacesGetRunningFixture(VyOSModuleTestCase):
def setUp(self):
super().setUp()
self.fixture = load_fixture("lag_interfaces_running.json")
def test_fixture_parses_bond0_mode(self):
self.set_running_config(self.fixture)
result = get_running_config(self.mock_vyos)
bond0 = next((e for e in result if e["name"] == "bond0"), None)
self.assertIsNotNone(bond0)
self.assertEqual(bond0["mode"], "active-backup")
def test_fixture_parses_hash_policy(self):
self.set_running_config(self.fixture)
result = get_running_config(self.mock_vyos)
bond0 = next(e for e in result if e["name"] == "bond0")
self.assertEqual(bond0["hash_policy"], "layer2")
def test_fixture_parses_arp_monitor(self):
self.set_running_config(self.fixture)
result = get_running_config(self.mock_vyos)
bond0 = next(e for e in result if e["name"] == "bond0")
self.assertIn("arp_monitor", bond0)
self.assertEqual(bond0["arp_monitor"]["interval"], 100)
self.assertIn("192.0.2.1", bond0["arp_monitor"]["target"])
def test_fixture_unwraps_bonding_key(self):
# wrap in extra "bonding" key as VyOS sometimes returns
wrapped = {"bonding": self.fixture}
self.set_running_config(wrapped)
result = get_running_config(self.mock_vyos)
self.assertTrue(len(result) > 0)
self.assertEqual(result[0]["name"], "bond0")
class TestVyOSLagInterfacesGetRunning(VyOSModuleTestCase):
def test_empty_returns_empty_list(self):
self.set_running_config({})
result = get_running_config(self.mock_vyos)
self.assertEqual(result, [])
def test_parses_mode(self):
self.set_running_config(
{
"bond0": {"mode": "802.3ad"},
},
)
result = get_running_config(self.mock_vyos)
self.assertEqual(result[0]["mode"], "802.3ad")
def test_parses_hash_policy(self):
self.set_running_config(
{
"bond0": {"hash-policy": "layer2+3"},
},
)
result = get_running_config(self.mock_vyos)
self.assertEqual(result[0]["hash_policy"], "layer2+3")
def test_parses_members(self):
self.set_running_config(
{
"bond0": {"member": {"interface": {"eth1": {}, "eth2": {}}}},
},
)
result = get_running_config(self.mock_vyos)
members = [m["member"] for m in result[0]["members"]]
self.assertIn("eth1", members)
self.assertIn("eth2", members)
def test_parses_arp_monitor_interval(self):
self.set_running_config(
{
"bond0": {"arp-monitor": {"interval": "100"}},
},
)
result = get_running_config(self.mock_vyos)
self.assertEqual(result[0]["arp_monitor"]["interval"], 100)
def test_parses_arp_monitor_target_dict(self):
self.set_running_config(
{
"bond0": {"arp-monitor": {"target": {"192.0.2.1": {}}}},
},
)
result = get_running_config(self.mock_vyos)
self.assertIn("192.0.2.1", result[0]["arp_monitor"]["target"])
def test_skips_type_keys(self):
self.set_running_config(
{
"bonding": {"bond0": {"mode": "802.3ad"}},
},
)
result = get_running_config(self.mock_vyos)
# "bonding" key should be skipped
names = [e["name"] for e in result]
self.assertNotIn("bonding", names)
class TestVyOSLagInterfacesNormalize(unittest.TestCase):
def test_normalize_basic(self):
config = [{"name": "bond0", "mode": "802.3ad", "hash_policy": "layer2"}]
result = _normalize(config)
self.assertIn("bond0", result)
self.assertEqual(result["bond0"]["mode"], "802.3ad")
self.assertEqual(result["bond0"]["hash_policy"], "layer2")
def test_normalize_members_sorted(self):
config = [
{
"name": "bond0",
"members": [{"member": "eth2"}, {"member": "eth1"}],
},
]
result = _normalize(config)
self.assertEqual(result["bond0"]["members"], ["eth1", "eth2"])
def test_normalize_arp_targets_sorted(self):
config = [
{
"name": "bond0",
"arp_monitor": {"interval": 100, "target": ["192.0.2.2", "192.0.2.1"]},
},
]
result = _normalize(config)
self.assertEqual(result["bond0"]["arp_targets"], ["192.0.2.1", "192.0.2.2"])
def test_normalize_empty(self):
result = _normalize([])
self.assertEqual(result, {})
class TestVyOSLagInterfacesBondCmds(unittest.TestCase):
def test_set_mode(self):
want = {"mode": "802.3ad"}
cmds = _bond_cmds("bond0", want, {})
self.assertIn(
("set", ["interfaces", "bonding", "bond0", "mode", "802.3ad"]),
cmds,
)
def test_set_hash_policy(self):
want = {"hash_policy": "layer2"}
cmds = _bond_cmds("bond0", want, {})
self.assertIn(
("set", ["interfaces", "bonding", "bond0", "hash-policy", "layer2"]),
cmds,
)
def test_set_member(self):
want = {"members": ["eth1"]}
cmds = _bond_cmds("bond0", want, {})
self.assertIn(
("set", ["interfaces", "bonding", "bond0", "member", "interface", "eth1"]),
cmds,
)
def test_set_arp_interval(self):
want = {"arp_interval": 100}
cmds = _bond_cmds("bond0", want, {})
self.assertIn(
("set", ["interfaces", "bonding", "bond0", "arp-monitor", "interval", "100"]),
cmds,
)
def test_set_arp_target(self):
want = {"arp_targets": ["192.0.2.1"]}
cmds = _bond_cmds("bond0", want, {})
self.assertIn(
("set", ["interfaces", "bonding", "bond0", "arp-monitor", "target", "192.0.2.1"]),
cmds,
)
def test_idempotent_mode(self):
want = {"mode": "802.3ad"}
have = {"mode": "802.3ad"}
cmds = _bond_cmds("bond0", want, have)
self.assertEqual(cmds, [])
def test_no_commands_when_empty_want(self):
cmds = _bond_cmds("bond0", {}, {})
self.assertEqual(cmds, [])
class TestVyOSLagInterfacesBuildCommands(unittest.TestCase):
def _have_bond0(self):
return [
{
"name": "bond0",
"mode": "active-backup",
"hash_policy": "layer2",
"arp_monitor": {"interval": 100, "target": ["192.0.2.1"]},
},
]
def test_merged_adds_bond(self):
config = [{"name": "bond0", "mode": "802.3ad"}]
cmds = build_commands(config, [], "merged")
self.assertIn(
("set", ["interfaces", "bonding", "bond0", "mode", "802.3ad"]),
cmds,
)
def test_merged_idempotent(self):
cmds = build_commands(self._have_bond0(), self._have_bond0(), "merged")
self.assertEqual(cmds, [])
def test_deleted_no_config_removes_all(self):
cmds = build_commands([], self._have_bond0(), "deleted")
self.assertIn(
("delete", ["interfaces", "bonding", "bond0"]),
cmds,
)
def test_deleted_with_name_removes_bond(self):
config = [{"name": "bond0"}]
cmds = build_commands(config, self._have_bond0(), "deleted")
self.assertIn(
("delete", ["interfaces", "bonding", "bond0"]),
cmds,
)
def test_deleted_idempotent_when_empty(self):
cmds = build_commands([], [], "deleted")
self.assertEqual(cmds, [])
def test_replaced_idempotent(self):
cmds = build_commands(self._have_bond0(), self._have_bond0(), "replaced")
self.assertEqual(cmds, [])
def test_overridden_removes_unlisted_bond(self):
config = [{"name": "bond1", "mode": "802.3ad"}]
cmds = build_commands(config, self._have_bond0(), "overridden")
self.assertIn(
("delete", ["interfaces", "bonding", "bond0"]),
cmds,
)
if __name__ == "__main__":
unittest.main()
|
