1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
|
# -*- coding: utf-8 -*-
from __future__ import absolute_import, division, print_function
__metaclass__ = type
import json
import os
import unittest
from unittest.mock import MagicMock
from ansible_collections.vyos.rest.plugins.modules.vyos_ntp_global import (
build_commands,
get_running_config,
normalize_config,
normalize_servers,
)
def load_fixture(filename):
fixtures_dir = os.path.join(os.path.dirname(__file__), "..", "fixtures")
path = os.path.join(fixtures_dir, filename)
with open(path) as f:
return json.load(f)
class VyOSModuleTestCase(unittest.TestCase):
def setUp(self):
self.mock_vyos = MagicMock()
self.mock_vyos.get_config = MagicMock(return_value={})
def set_running_config(self, data):
self.mock_vyos.get_config.return_value = data
class TestVyOSNtpGlobalNormalize(unittest.TestCase):
"""Test normalize_config and normalize_servers — no device needed."""
def test_normalize_config_empty(self):
result = normalize_config({})
self.assertEqual(result["allow_clients"], [])
self.assertEqual(result["listen_addresses"], [])
self.assertEqual(result["servers"], {})
def test_normalize_config_servers_sorted(self):
config = {
"servers": [
{"server": "b.example.com", "options": ["prefer", "noselect"]},
{"server": "a.example.com"},
],
}
result = normalize_config(config)
self.assertIn("a.example.com", result["servers"])
self.assertIn("b.example.com", result["servers"])
self.assertEqual(result["servers"]["b.example.com"], ["noselect", "prefer"])
def test_normalize_servers_dict_with_options(self):
raw = {
"time1.vyos.net": {},
"203.0.113.0": {"prefer": {}},
}
result = normalize_servers(raw)
self.assertEqual(result["time1.vyos.net"], [])
self.assertEqual(result["203.0.113.0"], ["prefer"])
def test_normalize_servers_list(self):
raw = ["time1.vyos.net", "time2.vyos.net"]
result = normalize_servers(raw)
self.assertEqual(result["time1.vyos.net"], [])
def test_normalize_servers_string(self):
result = normalize_servers("time1.vyos.net")
self.assertEqual(result["time1.vyos.net"], [])
class TestVyOSNtpGlobalGetRunning(VyOSModuleTestCase):
"""Test get_running_config parsing against fixture API responses."""
def setUp(self):
super().setUp()
self.fixture = load_fixture("ntp_global_running.json")
def test_parses_allow_clients(self):
self.set_running_config(self.fixture)
result = get_running_config(self.mock_vyos)
self.assertIn("10.6.6.0/24", result["allow_clients"])
def test_parses_listen_addresses(self):
self.set_running_config(self.fixture)
result = get_running_config(self.mock_vyos)
self.assertIn("10.1.3.1", result["listen_addresses"])
def test_parses_servers(self):
self.set_running_config(self.fixture)
result = get_running_config(self.mock_vyos)
self.assertIn("time1.vyos.net", result["servers"])
self.assertIn("203.0.113.0", result["servers"])
self.assertIn("prefer", result["servers"]["203.0.113.0"])
def test_empty_config_returns_empty(self):
self.set_running_config({})
result = get_running_config(self.mock_vyos)
self.assertEqual(result["allow_clients"], [])
self.assertEqual(result["servers"], {})
class TestVyOSNtpGlobalBuildCommands(unittest.TestCase):
"""Test build_commands diff logic — no device needed."""
def _have(self, **kwargs):
base = {"allow_clients": [], "listen_addresses": [], "servers": {}}
base.update(kwargs)
return base
def _want(self, **kwargs):
return self._have(**kwargs)
def test_merged_adds_new_server(self):
want = self._want(servers={"new.server.com": []})
have = self._have(servers={})
cmds = build_commands(want, have, "merged")
self.assertIn(("set", ["service", "ntp", "server", "new.server.com"]), cmds)
def test_merged_idempotent_existing_server(self):
want = self._want(servers={"time1.vyos.net": []})
have = self._have(servers={"time1.vyos.net": []})
cmds = build_commands(want, have, "merged")
self.assertEqual(cmds, [])
def test_merged_adds_server_option(self):
want = self._want(servers={"time1.vyos.net": ["prefer"]})
have = self._have(servers={"time1.vyos.net": []})
cmds = build_commands(want, have, "merged")
self.assertIn(("set", ["service", "ntp", "server", "time1.vyos.net", "prefer"]), cmds)
def test_replaced_removes_extra_server(self):
want = self._want(servers={"time1.vyos.net": []})
have = self._have(servers={"time1.vyos.net": [], "time2.vyos.net": []})
cmds = build_commands(want, have, "replaced")
self.assertIn(("delete", ["service", "ntp", "server", "time2.vyos.net"]), cmds)
def test_replaced_removes_extra_allow_client(self):
want = self._want(allow_clients=["10.1.0.0/24"])
have = self._have(allow_clients=["10.1.0.0/24", "10.2.0.0/24"])
cmds = build_commands(want, have, "replaced")
self.assertIn(
("delete", ["service", "ntp", "allow-client", "address", "10.2.0.0/24"]),
cmds,
)
def test_deleted_removes_all(self):
have = self._have(
servers={"time1.vyos.net": []},
allow_clients=["10.0.0.0/24"],
listen_addresses=["192.168.1.1"],
)
cmds = build_commands({}, have, "deleted")
self.assertEqual(len(cmds), 1)
self.assertEqual(cmds[0], ("delete", ["service", "ntp"]))
def test_deleted_idempotent_when_empty(self):
have = self._have(servers={}, allow_clients=[], listen_addresses=[])
cmds = build_commands({}, have, "deleted")
self.assertEqual(cmds, [])
def test_overridden_deletes_then_merges(self):
want = self._want(servers={"new.server.com": []})
have = self._have(servers={"old.server.com": []})
cmds = build_commands(want, have, "overridden")
ops_paths = [(c[0], c[1]) for c in cmds]
self.assertIn(("delete", ["service", "ntp", "server", "old.server.com"]), ops_paths)
self.assertIn(("set", ["service", "ntp", "server", "new.server.com"]), ops_paths)
self.assertNotIn(("delete", ["service", "ntp", "server"]), ops_paths)
def test_no_commands_when_already_correct(self):
state = {"allow_clients": ["10.0.0.0/24"], "listen_addresses": [], "servers": {}}
cmds = build_commands(state, state, "merged")
self.assertEqual(cmds, [])
if __name__ == "__main__":
unittest.main()
|
