diff options
author | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2010-04-27 15:20:38 -0700 |
---|---|---|
committer | Stephen Hemminger <stephen.hemminger@vyatta.com> | 2010-04-27 15:21:27 -0700 |
commit | 845d1bd87be28deb65db22e47e29ba7a89c37b4b (patch) | |
tree | 362396058f9b1e3970e5c15f88b8888cd487aef0 | |
parent | 59cae244d055a7b5ba9de460d3ebbb5700d6ab17 (diff) | |
download | vyatta-cfg-system-845d1bd87be28deb65db22e47e29ba7a89c37b4b.tar.gz vyatta-cfg-system-845d1bd87be28deb65db22e47e29ba7a89c37b4b.zip |
Make interface help completion strings consistent
Use same format/syntax over all interface types.
Bug 5257
-rw-r--r-- | templates/interfaces/bonding/node.def | 4 | ||||
-rw-r--r-- | templates/interfaces/bridge/node.def | 4 | ||||
-rw-r--r-- | templates/interfaces/ethernet/node.def | 4 | ||||
-rw-r--r-- | templates/interfaces/input/node.def | 3 | ||||
-rw-r--r-- | templates/interfaces/loopback/node.def | 3 | ||||
-rw-r--r-- | templates/interfaces/pseudo-ethernet/node.def | 4 | ||||
-rw-r--r-- | templates/interfaces/tunnel/node.def | 4 |
7 files changed, 15 insertions, 11 deletions
diff --git a/templates/interfaces/bonding/node.def b/templates/interfaces/bonding/node.def index bb1b9ae3..9e27ebad 100644 --- a/templates/interfaces/bonding/node.def +++ b/templates/interfaces/bonding/node.def @@ -1,7 +1,8 @@ tag: priority: 315 type: txt -help: Set bonding interface +help: Set bonding interface name +comp_help: Enter bonding interface name (bond0 - bond99) syntax:expression: pattern $VAR(@) "^bond[0-9]+$" \ ; "bonding must be (bond0-bond99)" begin: if [ ! -f /sys/class/net/bonding_masters ]; then @@ -18,4 +19,3 @@ delete: SLAVES=`cat /sys/class/net/$VAR(@)/bonding/slaves`; echo "bonded interface $VAR(@) still has slaves: $SLAVES" exit 1; fi -comp_help: Enter bond interface name (bond0 - bond99) diff --git a/templates/interfaces/bridge/node.def b/templates/interfaces/bridge/node.def index 55c961ba..343cf984 100644 --- a/templates/interfaces/bridge/node.def +++ b/templates/interfaces/bridge/node.def @@ -1,7 +1,8 @@ tag: priority: 310 type: txt -help: Set bridge interface +help: Set bridge interface name +comp_help: "Enter bridge interface name (br0 - br999)" syntax:expression: pattern $VAR(@) "^br[0-9]+$" ; "Must be (br0 - br999)" @@ -16,4 +17,3 @@ delete: if ! /opt/vyatta/sbin/vyatta-bridgegroup-depedency.pl \ sudo ip link set $VAR(@) down; sudo brctl delbr $VAR(@); -comp_help: "Enter bridge interface name (br0 - br999)" diff --git a/templates/interfaces/ethernet/node.def b/templates/interfaces/ethernet/node.def index 081cabb5..0b67836b 100644 --- a/templates/interfaces/ethernet/node.def +++ b/templates/interfaces/ethernet/node.def @@ -1,7 +1,9 @@ tag: priority: 318 type: txt -help: Set ethernet interface +help: Set Ethernet interface name +comp_help: Enter Ethernet interface name (eth0 - eth999) + allowed: /opt/vyatta/sbin/vyatta-interfaces.pl --show=ethernet syntax:expression: pattern $VAR(@) "^eth[0-9]+$" \ ; "interface ethernet $VAR(@): not a valid name" diff --git a/templates/interfaces/input/node.def b/templates/interfaces/input/node.def index 2695b8a6..b90cb0b3 100644 --- a/templates/interfaces/input/node.def +++ b/templates/interfaces/input/node.def @@ -2,9 +2,10 @@ tag: priority: 310 # before real devices that redirect type: txt help: Set input functional block (IFB) interface +comp_help: Enter input functional block interface name (ifb0 - ifb999) + syntax:expression: pattern $VAR(@) "^ifb[0-9]+$" ; "name must be (ifb0-ifb999)" begin: [ -d /sys/module/ifb ] || sudo modprobe ifb numifbs=0 create: sudo ip link add $VAR(@) type ifb && sudo ip link set $VAR(@) up delete: sudo ip link delete dev $VAR(@) -comp_help: Enter input functional block interface name (ifb0 - ifb999) diff --git a/templates/interfaces/loopback/node.def b/templates/interfaces/loopback/node.def index 8312aafe..ae166e7b 100644 --- a/templates/interfaces/loopback/node.def +++ b/templates/interfaces/loopback/node.def @@ -1,7 +1,8 @@ tag: priority: 300 type: txt -help: Set loopback interface +help: Set loopback interface name +comp_help: Enter looback interface name (lo) syntax:expression: exec \ "/opt/vyatta/sbin/vyatta-interfaces.pl --dev=$VAR(@) --check=loopback" allowed: /opt/vyatta/sbin/vyatta-interfaces.pl --show=loopback diff --git a/templates/interfaces/pseudo-ethernet/node.def b/templates/interfaces/pseudo-ethernet/node.def index cdbff5c8..14ee0a34 100644 --- a/templates/interfaces/pseudo-ethernet/node.def +++ b/templates/interfaces/pseudo-ethernet/node.def @@ -1,7 +1,8 @@ tag: priority: 390 type: txt -help: Set Virtual Ethernet device +help: Set Pseudo Ethernet device name +comp_help: Enter Pseudo Ethernet interface name (peth0 - peth999) syntax:expression: pattern $VAR(@) "^peth[0-9]+$" \ ; "name must be (peth0-peth999)" commit:expression: $VAR(link) != "" @@ -10,4 +11,3 @@ create: sudo ip link add $VAR(@) link $VAR(link/@) type macvlan || exit 1 sudo ip link set $VAR(@) up /opt/vyatta/sbin/vyatta-link-detect $VAR(@) on delete: sudo ip link delete dev $VAR(@) type macvlan -comp_help: Enter virtual ethernet interface name (peth0 - peth999) diff --git a/templates/interfaces/tunnel/node.def b/templates/interfaces/tunnel/node.def index ba3fa49a..c4446163 100644 --- a/templates/interfaces/tunnel/node.def +++ b/templates/interfaces/tunnel/node.def @@ -1,7 +1,8 @@ tag: priority: 380 type: txt -help: Set tunnel interface +help: Set tunnel interface name +comp_help: Enter tunnel interface name (tun0 - tun999) syntax:expression: pattern $VAR(@) "^tun[0-9]+$" \ ; "tunnel must be (tun0-tun999)" @@ -28,4 +29,3 @@ create:expression: "\ delete:expression: "sudo ip tunnel del $VAR(@)" ; "Error deleting $VAR(@)" -comp_help: Enter tunnel interface name (tun0 - tun999) |