workaround for bug 5388

* disallow double quote (") character in config values.
(cherry picked from commit 143d9b4ed9fcf3ac29fd8bc8c6af6bb1921fada8)

1 files changed, 13 insertions, 8 deletions

diff --git a/src/cli_new.c b/src/cli_new.c
index f88e5c3..87f8e8b 100644
--- a/src/cli_new.c
+++ b/src/cli_new.c
@@ -2180,15 +2180,20 @@ boolean validate_value(vtw_def *def, char *cp)
   /* certain characters are not allowed */
   {
     int i = 0;
+    static const char *disallowed[] = {
+      "'", "single quote (')",
+      "\n", "newline",
+      "\"", "double quote (\")",
+      NULL, NULL
+    };
     for (i = 0; i < strlen(cp); i++) {
-      if (cp[i] == '\'') {
-        OUTPUT_USER("Cannot use the \"'\" (single quote) character "
-                    "in a value string\n");
-        return FALSE;
-      }
-      if (cp[i] == '\n') {
-        OUTPUT_USER("Cannot use the newline character in a value string\n");
-        return FALSE;
+      int j = 0;
+      for (j = 0; disallowed[j]; j += 2) {
+        if (cp[i] == disallowed[j][0]) {
+          OUTPUT_USER("Cannot use the %s character in a value string\n",
+                      disallowed[j + 1]);
+          return FALSE;
+        }
       }
     }
   }