summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Estabrook <jestabro@vyos.io>2026-08-10 12:31:41 -0500
committerJohn Estabrook <jestabro@vyos.io>2026-08-10 12:59:14 -0500
commitd530a13a42bb1f0fb8facb1828813939d3c0fa1a (patch)
treedc84a5b31904297701bcfb0859f6d21c94d2fea4
parent1eec1be8a08fa8a26622c7a0df6d0f0b6853afde (diff)
downloadvyconf-d530a13a42bb1f0fb8facb1828813939d3c0fa1a.tar.gz
vyconf-d530a13a42bb1f0fb8facb1828813939d3c0fa1a.zip
T9168: pin version 3.1.1 of ocaml-protoc / pbrt
The automated review 0d61bd73fc was incorrect: the files were in fact generated by ocaml-protoc 3.1.1, and that is the stable and tested version for generation/build. Versions of ocaml-protoc / pbrt >= 4.x are not appropriate for regenerating *_pbrt files. However, versions < 3 are not appropriate for building the package.
-rw-r--r--vyconf.opam6
1 files changed, 1 insertions, 5 deletions
diff --git a/vyconf.opam b/vyconf.opam
index 1b1958d..e7c089a 100644
--- a/vyconf.opam
+++ b/vyconf.opam
@@ -16,11 +16,7 @@ build: [
depends: [
"menhir" {build}
"dune" {build & >= "1.4.0"}
- # The committed src/*_pbt.ml were generated by ocaml-protoc 2.x. Version 3.0
- # emits private record types with presence tracking, which the hand-written
- # call sites cannot construct. Pin to 2.x until the generated code + call
- # sites are migrated to the 3.x API.
- "ocaml-protoc" {build & < "3.0"}
+ "ocaml-protoc" {build & = "3.1.1"}
"ounit2" {build}
"vyos1x-config" {build}
"lwt" {build & >= "4.1.0"}