diff options
| author | Nataliia Solomko <natalirs1985@gmail.com> | 2026-04-23 14:20:10 +0300 |
|---|---|---|
| committer | Nataliia Solomko <natalirs1985@gmail.com> | 2026-04-28 13:19:24 +0300 |
| commit | 0ea58ccad9eccb5fa34da146cfd2ed9f9844e02f (patch) | |
| tree | d534650ddaf2484d036b4c5961873a8418f780c5 | |
| parent | 45509acb7fb32f4680f2c03162846b21b7aa2f59 (diff) | |
| download | vyos-1x-0ea58ccad9eccb5fa34da146cfd2ed9f9844e02f.tar.gz vyos-1x-0ea58ccad9eccb5fa34da146cfd2ed9f9844e02f.zip | |
op-mode: T8305: Fix completion for "show isis neighbor <system-id>" command
Problem: The completion helper for `show isis neighbor` showed `system-id` as a literal keyword suggestion,
leading users to type exactly `system-id` instead of an actual neighbor name. Doing so returned
`Invalid system id system-id`. In reality, FRR accepts any real system-id (e.g. vyos01)
and returns correct per-neighbor details — the issue was purely in the completion hint misguiding the user.
Fix: Replaced the static `system-id` placeholder in the completion helper with a dynamic script that queries
`vtysh -c "show isis hostname"` and offers real neighbor names as tab-completion suggestions.
| -rw-r--r-- | op-mode-definitions/include/isis-common.xml.i | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/op-mode-definitions/include/isis-common.xml.i b/op-mode-definitions/include/isis-common.xml.i index 17132b857..3ddbfbf82 100644 --- a/op-mode-definitions/include/isis-common.xml.i +++ b/op-mode-definitions/include/isis-common.xml.i @@ -106,7 +106,7 @@ <properties> <help>Show specific IS-IS neighbor adjacency </help> <completionHelp> - <list>system-id</list> + <script>vtysh -c "show isis hostname" | awk 'NR>2 && $1 != "*" {print $NF}' | sort -u</script> </completionHelp> </properties> <command>${vyos_op_scripts_dir}/vtysh_wrapper.sh $@</command> |