diff options
| author | Christian Breunig <christian@breunig.cc> | 2025-09-04 21:35:37 +0200 |
|---|---|---|
| committer | Christian Breunig <christian@breunig.cc> | 2025-09-04 21:35:37 +0200 |
| commit | 5fee0201535fafceabd384ff3da3426e1fbd13fd (patch) | |
| tree | af6f4369dd1f96d56346f1b7d4a131fb2b9cca45 | |
| parent | 4e0ed81965f0e3efd8054ccfc0403883864696e1 (diff) | |
| download | vyos-1x-5fee0201535fafceabd384ff3da3426e1fbd13fd.tar.gz vyos-1x-5fee0201535fafceabd384ff3da3426e1fbd13fd.zip | |
T7787: Makefile check for unused-imports should be mandatory
Currently our make target for "unused-imports" check is optional and a
"suggestion". As we now also use pylint to check for missing imports and code
issues, we will now make the unused import check mandatory.
This improves overall code quality.
| -rw-r--r-- | .github/workflows/check-unused-imports.yml | 14 | ||||
| -rw-r--r-- | Makefile | 6 |
2 files changed, 2 insertions, 18 deletions
diff --git a/.github/workflows/check-unused-imports.yml b/.github/workflows/check-unused-imports.yml deleted file mode 100644 index d6dd61483..000000000 --- a/.github/workflows/check-unused-imports.yml +++ /dev/null @@ -1,14 +0,0 @@ -name: Check for unused imports using Pylint -on: - pull_request_target: - branches: - - current - -permissions: - pull-requests: write - contents: read - -jobs: - check-unused-imports: - uses: vyos/.github/.github/workflows/check-unused-imports.yml@current - secrets: inherit @@ -119,6 +119,8 @@ check_migration_scripts_executable: pylint: interface_definitions @echo Running "pylint --errors-only ..." @PYTHONPATH=python/ pylint --errors-only $(shell git ls-files python/vyos/ifconfig/*.py python/vyos/utils/*.py src/conf_mode/*.py src/op_mode/*.py src/migration-scripts src/services/vyos*) + @echo Running "pylint to check for unused imports ..." + @PYTHONPATH=python/ pylint --disable=all --enable=W0611 $(shell git ls-files *.py src/migration-scripts src/services) .PHONY: j2lint j2lint: @@ -131,10 +133,6 @@ endif sonar: sonar-scanner -X -Dsonar.login=${SONAR_TOKEN} -.PHONY: unused-imports -unused-imports: - @pylint --disable=all --enable=W0611 $(shell git ls-files *.py src/migration-scripts src/services) - deb: dpkg-buildpackage -uc -us -tc -b |