summaryrefslogtreecommitdiff
path: root/interface-definitions/include
diff options
context:
space:
mode:
authorChristian Breunig <christian@breunig.cc>2026-02-15 12:08:20 +0100
committerChristian Breunig <christian@breunig.cc>2026-02-15 12:58:14 +0100
commit6b8139a9ed7426356f9515603e855fb89e5506af (patch)
tree3c6434208e60000b50f6bfba42207e4f4642c9bd /interface-definitions/include
parent8a5094e0bd4c1be7000bc520d81ac03f6daff3f3 (diff)
downloadvyos-1x-6b8139a9ed7426356f9515603e855fb89e5506af.tar.gz
vyos-1x-6b8139a9ed7426356f9515603e855fb89e5506af.zip
xml: T8271: consolidate source-destination-group.xml.i and it's IPv4 equivalent
$ make interface_definitions $ git add -f templates-cfg $ ... refactor $ make interface_definitions $ git diff templates-cfg No change in any node.def file detected.
Diffstat (limited to 'interface-definitions/include')
-rw-r--r--interface-definitions/include/firewall/common-rule-ipv4-raw.xml.i16
-rw-r--r--interface-definitions/include/firewall/common-rule-ipv4.xml.i16
-rw-r--r--interface-definitions/include/firewall/source-destination-group.xml.i28
-rw-r--r--interface-definitions/include/nat-rule.xml.i14
4 files changed, 38 insertions, 36 deletions
diff --git a/interface-definitions/include/firewall/common-rule-ipv4-raw.xml.i b/interface-definitions/include/firewall/common-rule-ipv4-raw.xml.i
index e8da1a0e1..85f1071a6 100644
--- a/interface-definitions/include/firewall/common-rule-ipv4-raw.xml.i
+++ b/interface-definitions/include/firewall/common-rule-ipv4-raw.xml.i
@@ -27,7 +27,12 @@
#include <include/firewall/geoip.xml.i>
#include <include/firewall/mac-address.xml.i>
#include <include/firewall/port.xml.i>
- #include <include/firewall/source-destination-group.xml.i>
+ #include <include/firewall/source-destination-group-ipv4.xml.i>
+ <node name="group">
+ <children>
+ #include <include/firewall/mac-group.xml.i>
+ </children>
+ </node>
</children>
</node>
<node name="source">
@@ -41,7 +46,12 @@
#include <include/firewall/geoip.xml.i>
#include <include/firewall/mac-address.xml.i>
#include <include/firewall/port.xml.i>
- #include <include/firewall/source-destination-group.xml.i>
+ #include <include/firewall/source-destination-group-ipv4.xml.i>
+ <node name="group">
+ <children>
+ #include <include/firewall/mac-group.xml.i>
+ </children>
+ </node>
</children>
</node>
-<!-- include end --> \ No newline at end of file
+<!-- include end -->
diff --git a/interface-definitions/include/firewall/common-rule-ipv4.xml.i b/interface-definitions/include/firewall/common-rule-ipv4.xml.i
index b67ef25dc..b6c1b13b3 100644
--- a/interface-definitions/include/firewall/common-rule-ipv4.xml.i
+++ b/interface-definitions/include/firewall/common-rule-ipv4.xml.i
@@ -14,7 +14,12 @@
#include <include/firewall/geoip.xml.i>
#include <include/firewall/mac-address.xml.i>
#include <include/firewall/port.xml.i>
- #include <include/firewall/source-destination-group.xml.i>
+ #include <include/firewall/source-destination-group-ipv4.xml.i>
+ <node name="group">
+ <children>
+ #include <include/firewall/mac-group.xml.i>
+ </children>
+ </node>
#include <include/firewall/source-destination-dynamic-group.xml.i>
#include <include/firewall/source-destination-remote-group.xml.i>
</children>
@@ -38,9 +43,14 @@
#include <include/firewall/geoip.xml.i>
#include <include/firewall/mac-address.xml.i>
#include <include/firewall/port.xml.i>
- #include <include/firewall/source-destination-group.xml.i>
+ #include <include/firewall/source-destination-group-ipv4.xml.i>
+ <node name="group">
+ <children>
+ #include <include/firewall/mac-group.xml.i>
+ </children>
+ </node>
#include <include/firewall/source-destination-dynamic-group.xml.i>
#include <include/firewall/source-destination-remote-group.xml.i>
</children>
</node>
-<!-- include end --> \ No newline at end of file
+<!-- include end -->
diff --git a/interface-definitions/include/firewall/source-destination-group.xml.i b/interface-definitions/include/firewall/source-destination-group.xml.i
deleted file mode 100644
index 06bd319ed..000000000
--- a/interface-definitions/include/firewall/source-destination-group.xml.i
+++ /dev/null
@@ -1,28 +0,0 @@
-<!-- include start from firewall/source-destination-group.xml.i -->
-<node name="group">
- <properties>
- <help>Group</help>
- </properties>
- <children>
- <leafNode name="address-group">
- <properties>
- <help>Group of addresses</help>
- <completionHelp>
- <path>firewall group address-group</path>
- </completionHelp>
- </properties>
- </leafNode>
- <leafNode name="network-group">
- <properties>
- <help>Group of networks</help>
- <completionHelp>
- <path>firewall group network-group</path>
- </completionHelp>
- </properties>
- </leafNode>
- #include <include/firewall/mac-group.xml.i>
- #include <include/firewall/domain-group.xml.i>
- #include <include/firewall/port-group.xml.i>
- </children>
-</node>
-<!-- include end -->
diff --git a/interface-definitions/include/nat-rule.xml.i b/interface-definitions/include/nat-rule.xml.i
index 0a7179ff1..3d5a6ede1 100644
--- a/interface-definitions/include/nat-rule.xml.i
+++ b/interface-definitions/include/nat-rule.xml.i
@@ -21,7 +21,12 @@
#include <include/firewall/fqdn.xml.i>
#include <include/nat-address.xml.i>
#include <include/nat-port.xml.i>
- #include <include/firewall/source-destination-group.xml.i>
+ #include <include/firewall/source-destination-group-ipv4.xml.i>
+ <node name="group">
+ <children>
+ #include <include/firewall/mac-group.xml.i>
+ </children>
+ </node>
</children>
</node>
#include <include/generic-disable-node.xml.i>
@@ -319,7 +324,12 @@
#include <include/firewall/fqdn.xml.i>
#include <include/nat-address.xml.i>
#include <include/nat-port.xml.i>
- #include <include/firewall/source-destination-group.xml.i>
+ #include <include/firewall/source-destination-group-ipv4.xml.i>
+ <node name="group">
+ <children>
+ #include <include/firewall/mac-group.xml.i>
+ </children>
+ </node>
</children>
</node>
</children>