pppoe: T3621: validate that both username and password are set

A validator is missing checking that if authentication is used on a PPPoE
interface, both username and password are set.

(cherry picked from commit 0361c3ac449f183476f7aee31439417d9f7f8012)

1 files changed, 14 insertions, 0 deletions

diff --git a/smoketest/scripts/cli/test_interfaces_pppoe.py b/smoketest/scripts/cli/test_interfaces_pppoe.py
index b8682fe71..3412ebae0 100755
--- a/smoketest/scripts/cli/test_interfaces_pppoe.py
+++ b/smoketest/scripts/cli/test_interfaces_pppoe.py
@@ -179,5 +179,19 @@ class PPPoEInterfaceTest(VyOSUnitTestSHIM.TestCase):
             tmp = re.findall(f'systemctl restart dhcp6c@{interface}.service', tmp)
             self.assertTrue(tmp)
 
+    def test_pppoe_authentication(self):
+        # When username or password is set - so must be the other
+        interface = 'pppoe0'
+        self.cli_set(base_path + [interface, 'authentication', 'user', 'vyos'])
+        self.cli_set(base_path + [interface, 'source-interface', self._source_interface])
+        self.cli_set(base_path + [interface, 'ipv6', 'address', 'autoconf'])
+
+        # check validate() - if user is set, so must be the password
+        with self.assertRaises(ConfigSessionError):
+            self.cli_commit()
+
+        self.cli_set(base_path + [interface, 'authentication', 'password', 'vyos'])
+        self.cli_commit()
+
 if __name__ == '__main__':
     unittest.main(verbosity=2)