diff options
| author | Paul Belanger <pabelanger@redhat.com> | 2020-06-08 16:03:27 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-06-08 20:03:27 +0000 |
| commit | 61314778e0a605c50b4fc1d918193771492c52fb (patch) | |
| tree | 2be70db4aa16ceb7e75be6e11dc09d4bc4b0e556 /tests/unit | |
| parent | 06235439435396c852535c2569542939bf65ef43 (diff) | |
| download | vyos-ansible-collection-61314778e0a605c50b4fc1d918193771492c52fb.tar.gz vyos-ansible-collection-61314778e0a605c50b4fc1d918193771492c52fb.zip | |
Fixes needed for sanity (#40)
Fixes needed for sanity
Reviewed-by: https://github.com/apps/ansible-zuul
Diffstat (limited to 'tests/unit')
4 files changed, 16 insertions, 18 deletions
diff --git a/tests/unit/modules/network/vyos/test_vyos_firewall_interfaces.py b/tests/unit/modules/network/vyos/test_vyos_firewall_interfaces.py index 92d2a4f..2a9a81c 100644 --- a/tests/unit/modules/network/vyos/test_vyos_firewall_interfaces.py +++ b/tests/unit/modules/network/vyos/test_vyos_firewall_interfaces.py @@ -303,7 +303,7 @@ class TestVyosFirewallInterfacesModule(TestVyosModule): access_rules=[ dict( afi="ipv4", - rules=[dict(name="INBOUND", direction="in"),], + rules=[dict(name="INBOUND", direction="in")], ), dict( afi="ipv6", diff --git a/tests/unit/modules/network/vyos/test_vyos_firewall_rules.py b/tests/unit/modules/network/vyos/test_vyos_firewall_rules.py index 86fcc65..8d59e19 100644 --- a/tests/unit/modules/network/vyos/test_vyos_firewall_rules.py +++ b/tests/unit/modules/network/vyos/test_vyos_firewall_rules.py @@ -686,9 +686,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): def test_vyos_firewall_v4_rule_sets_del_01(self): set_module_args( dict( - config=[ - dict(afi="ipv4", rule_sets=[dict(name="V4-INGRESS"),]) - ], + config=[dict(afi="ipv4", rule_sets=[dict(name="V4-INGRESS")])], state="deleted", ) ) @@ -699,8 +697,8 @@ class TestVyosFirewallRulesModule(TestVyosModule): set_module_args( dict( config=[ - dict(afi="ipv4", rule_sets=[dict(name="V4-INGRESS"),]), - dict(afi="ipv6", rule_sets=[dict(name="V6-INGRESS"),]), + dict(afi="ipv4", rule_sets=[dict(name="V4-INGRESS")]), + dict(afi="ipv6", rule_sets=[dict(name="V6-INGRESS")]), ], state="deleted", ) @@ -720,8 +718,8 @@ class TestVyosFirewallRulesModule(TestVyosModule): set_module_args( dict( config=[ - dict(afi="ipv4", rule_sets=[dict(name="V4-ING"),]), - dict(afi="ipv6", rule_sets=[dict(name="V6-ING"),]), + dict(afi="ipv4", rule_sets=[dict(name="V4-ING")]), + dict(afi="ipv6", rule_sets=[dict(name="V6-ING")]), ], state="deleted", ) diff --git a/tests/unit/modules/network/vyos/test_vyos_ospfv2.py b/tests/unit/modules/network/vyos/test_vyos_ospfv2.py index b825066..3d558b8 100644 --- a/tests/unit/modules/network/vyos/test_vyos_ospfv2.py +++ b/tests/unit/modules/network/vyos/test_vyos_ospfv2.py @@ -99,7 +99,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): dict( area_id="4", area_type=dict(stub=dict(default_cost=10)), - network=[dict(address="192.0.2.0/24"),], + network=[dict(address="192.0.2.0/24")], range=[ dict(address="192.0.3.0/24", cost=10), dict(address="192.0.4.0/24", cost=12), @@ -143,7 +143,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): dict( area_id="14", area_type=dict(stub=dict(default_cost=20)), - network=[dict(address="192.0.12.0/24"),], + network=[dict(address="192.0.12.0/24")], range=[ dict(address="192.0.13.0/24", cost=10), dict(address="192.0.14.0/24", cost=12), @@ -207,7 +207,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): dict( area_id="15", area_type=dict(stub=dict(default_cost=10)), - network=[dict(address="192.0.12.0/24"),], + network=[dict(address="192.0.12.0/24")], range=[ dict(address="192.0.13.0/24", cost=10), dict(address="192.0.14.0/24", cost=12), @@ -251,7 +251,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): dict( area_id="14", area_type=dict(stub=dict(default_cost=20)), - network=[dict(address="192.0.12.0/24"),], + network=[dict(address="192.0.12.0/24")], range=[ dict(address="192.0.13.0/24", cost=10), dict(address="192.0.14.0/24", cost=12), @@ -401,7 +401,7 @@ set protocols ospf redistribute bgp metric-type '2'""" dict( area_id="4", area_type=dict(stub=dict(default_cost=10)), - network=[dict(address="192.0.2.0/24"),], + network=[dict(address="192.0.2.0/24")], range=[ dict(address="192.0.3.0/24", cost=10), dict(address="192.0.4.0/24", cost=12), diff --git a/tests/unit/modules/network/vyos/test_vyos_ospfv3.py b/tests/unit/modules/network/vyos/test_vyos_ospfv3.py index 1d9cb3a..9c016da 100644 --- a/tests/unit/modules/network/vyos/test_vyos_ospfv3.py +++ b/tests/unit/modules/network/vyos/test_vyos_ospfv3.py @@ -101,7 +101,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): ), dict( area_id="3", - range=[dict(address="2001:db40::/32"),], + range=[dict(address="2001:db40::/32")], ), ], ), @@ -139,7 +139,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): ), dict( area_id="13", - range=[dict(address="2001:db44::/32"),], + range=[dict(address="2001:db44::/32")], ), ], ), @@ -203,7 +203,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): ), dict( area_id="14", - range=[dict(address="2001:db40::/32"),], + range=[dict(address="2001:db40::/32")], ), ], ), @@ -238,7 +238,7 @@ class TestVyosFirewallRulesModule(TestVyosModule): ), dict( area_id="13", - range=[dict(address="2001:db44::/32"),], + range=[dict(address="2001:db44::/32")], ), ], ), @@ -323,7 +323,7 @@ set protocols ospfv3 redistribute 'bgp'""" ), dict( area_id="3", - range=[dict(address="2001:db40::/32"),], + range=[dict(address="2001:db40::/32")], ), ], ), |