summaryrefslogtreecommitdiff
path: root/tests
AgeCommit message (Collapse)Author
2024-03-05Avoid unsafe conditions for integration tests (#340)Rahmanim Benny
* Avoid unsafe conditions for integration tests * Remove .idea/ folder * remove another jinja templating expression from asserts condition * remove shortname jinja templating expression from asserts condition * Update changelog * changelog updates
2023-12-06Fix prefix-lists Integration tests (#338)Vinay M
* Fix prefix-lists Integration tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove autoversion * fix galaxy.yml * sanity fix * sanity ignore * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix ignore file --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2023-05-09Fix integration test connection var (#325)Kate Case
* Fix integration test connection var * Fix straggler
2023-05-03Add ansible-lint (#322)Kate Case
* Add ansible-lint * Fix some tasks * Ignore ignore_errors * Stop prettier and yamllint from fighting
2023-04-05Copy ignore-2.16.txt from ignore-2.15.txt (#310)Kate Case
2023-03-28Delete bond2 interface when clearing config (#307)Kate Case
2023-03-28Always clear config before setting base config in tests. (#306)Kate Case
* Always clear config before setting base config in tests. * Clear bond before removing
2023-02-27Update Unit Tests (#297)Kate Case
* Remove Python < 3.6 wrappers * Update imports
2023-02-08[pre-commit.ci] pre-commit autoupdate (#291)pre-commit-ci[bot]
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 22.12.0 → 23.1.0](https://github.com/psf/black/compare/22.12.0...23.1.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2023-02-07[command] run at least once when retries is 0 (#292)Kate Case
* [command] run at least once when retries is 0 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2023-01-25Add prettier and isort to pre-commit. (#270)Kate Case
* Add prettier and isort to pre-commit. * Bump line-length to 100 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2022-10-13Remove deprecated modules and provider (#277)Kate Case
* Remove deprecated modules and provider * Remove tests for removed modules * Remove references to vyos_argument_spec
2022-10-12Remove tests for net_* modules (#278)Kate Case
2022-10-12Copy ignore-2.15.txt from ignore-2.14.txt (#275)Kate Case
Fixes #274
2022-09-02Fix `pre-commit` Issues (#223)Shawn Wilsher
* Fix `pre-commit` Issues This change fixes `.pre-commit-config.yaml` so that `main` no longer has errors on it. To accomplish that, two things had to be done: * Update the version of `black` that `pre-commit` uses to match what `tox` uses. * Run `pre-commit run --all-files` and commit the results Co-authored-by: Kate Case <this.is@katherineca.se>
2022-08-22Fix arguments-renamed errors (#268)Kate Case
2022-05-23Add support for icmpv6 type-name in firewall_rules (#258)GomathiselviS
Add support for icmpv6 type-name in firewall_rules Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY Fixes #257 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Sagar Paul <sagpaul@redhat.com>
2022-04-25Add fqcn to ansible_connection to support stable-2.9 (#254)GomathiselviS
Add fqcn to ansible_connection to support stable-2.9 Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY strip_prompt argument is supported only in netcommon network_cli . Vyos jobs on stable-2.9 is failing with the following error, as this argument is not supported ansibe/ansible. This PR sets ansible_connection to ansible.netcommon.network_cli, so that the correct module is used. 2022-04-21 21:14:54.059623 | controller | capabilities = Connection(module._socket_path).get_capabilities() 2022-04-21 21:14:54.059626 | controller | File "/tmp/ansible_vyos.vyos.vyos_config_payload_hjioy2__/ansible_vyos.vyos.vyos_config_payload.zip/ansible/module_utils/connection.py", line 190, in __rpc__ 2022-04-21 21:14:54.059629 | controller | raise ConnectionError(to_text(msg, errors='surrogate_then_replace'), code=code) 2022-04-21 21:14:54.059632 | controller | fatal: [vyos]: FAILED! => { 2022-04-21 21:14:54.059635 | controller | "changed": false, 2022-04-21 21:14:54.059638 | controller | "invocation": { 2022-04-21 21:14:54.059641 | controller | "module_args": { 2022-04-21 21:14:54.059644 | controller | "backup": false, 2022-04-21 21:14:54.059647 | controller | "backup_options": null, 2022-04-21 21:14:54.059650 | controller | "comment": "configured by vyos_config", 2022-04-21 21:14:54.059653 | controller | "config": null, 2022-04-21 21:14:54.059656 | controller | "lines": [ 2022-04-21 21:14:54.059658 | controller | "delete interfaces ethernet eth1", 2022-04-21 21:14:54.059661 | controller | "delete interfaces ethernet eth2" 2022-04-21 21:14:54.059664 | controller | ], 2022-04-21 21:14:54.059667 | controller | "match": "none", 2022-04-21 21:14:54.059670 | controller | "provider": null, 2022-04-21 21:14:54.059673 | controller | "save": false, 2022-04-21 21:14:54.059676 | controller | "src": null 2022-04-21 21:14:54.059678 | controller | } 2022-04-21 21:14:54.059682 | controller | }, 2022-04-21 21:14:54.059685 | controller | "msg": "send() got an unexpected keyword argument 'strip_prompt'" ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
2022-04-21change default subset to min (#252)GomathiselviS
vyos_facts: change default subset to min Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY Fixes #231 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
2022-04-04Create symmlinks for redirection of vyos modules (#244)GomathiselviS
Create symmlinks for redirection of vyos modules Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Sagar Paul <sagpaul@redhat.com> Reviewed-by: None <None>
2022-03-10Change preconfig hostname in integration test (#243)GomathiselviS
Change preconfig hostname in integration test SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: None <None>
2022-03-01Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py (#240)GomathiselviS
Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py SUMMARY Fixes #239 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com> Reviewed-by: Sagar Paul <sagpaul@redhat.com> Reviewed-by: GomathiselviS <None> Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com> Reviewed-by: None <None>
2022-02-25firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the ↵Andrew Gunnerson
same name (#236) firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the same name SUMMARY VyOS supports IPv4 and IPv6 rule sets having the same name, but there are a couple places in the Ansible module that don't handle this situation. The fact gathering for ansible_network_resources.firewall_rules has been updated to look for name <name> or ipv6-name <name> instead of just <name>. The vyos_firewall_rules module has been updated to take the afi into consideration when comparing the have and want states. V4-EGRESS and V6-EGRESS have been renamed to just EGRESS in the tests. The existing tests seem to be complete enough to test this same-name situation. (V4-INGRESS and V6-INGRESS were not renamed.) ISSUE TYPE Bugfix Pull Request COMPONENT NAME vyos_facts and vyos_firewall_rules ADDITIONAL INFORMATION An example of a configuration that was originally causing an issue: (Click to expand): name wan-lan { default-action drop rule 1 { action accept state { established enable related enable } } rule 2 { action drop log enable state { invalid enable } } } ipv6-name wan-lan { default-action drop rule 1 { action accept state { established enable related enable } } rule 2 { action drop log enable state { invalid enable } } rule 10 { action accept protocol icmpv6 } } With this configuration, ansible_network_resources.firewall_rules would show the icmpv6 rule under both ipv4 and ipv6: (Click to expand): [ { "afi": "ipv4", "rule_sets": [ { "default_action": "drop", "name": "wan-lan", "rules": [ { "action": "accept", "number": 1, "state": { "established": true, "related": true } }, { "action": "drop", "number": 2, "state": { "invalid": true } }, { "action": "accept", "number": 10, "protocol": "icmpv6" } ] }, ] }, { "afi": "ipv6", "rule_sets": [ { "default_action": "drop", "name": "wan-lan", "rules": [ { "action": "accept", "number": 1, "state": { "established": true, "related": true } }, { "action": "drop", "number": 2, "state": { "invalid": true } }, { "action": "accept", "number": 10, "protocol": "icmpv6" } ] }, ] } ] A similar issue would happen when using vyos_firewall_rules as well, where it would attempt to change rules for the wrong afi. Reviewed-by: GomathiselviS <None> Reviewed-by: None <None>
2022-02-22vyos_firewall_rules: Add support for log enable on individual rules (#238)GomathiselviS
vyos_firewall_rules: Add support for log enable on individual rules SUMMARY ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com> Reviewed-by: None <None>
2022-02-17Add Vyos hostname resource module (#237)GomathiselviS
Add Vyos hostname resource module SUMMARY ISSUE TYPE New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com> Reviewed-by: None <None>
2022-02-01Vyos snmp_server Resource Module (#227)GomathiselviS
Vyos snmp_server Resource Module SUMMARY Added vyos_snmp_server resource module ISSUE TYPE New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com> Reviewed-by: Ashwini Mhatre <mashu97@gmail.com> Reviewed-by: None <None>
2022-01-19Enable configuring ntp server pool in ntp_global (#225)GomathiselviS
Enable configuring ntp server pool in ntp_global Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY Fixes #221 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Shawn Wilsher <None> Reviewed-by: None <None>
2021-12-08tests: remove unintended .swp file (#218)David Moreau Simard
tests: remove unintended .swp file SUMMARY Depends-On: #220 .swp files are VI temporary files and it was likely not intended to be added to the repository. ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests Reviewed-by: GomathiselviS <None> Reviewed-by: None <None>
2021-10-02Add vyos_ntp resource module (#175)YVarshitha
Add vyos_ntp resource module SUMMARY Resource module vyos_ntp ISSUE TYPE New Module Pull Request COMPONENT NAME vyos_ntp ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <None> Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com> Reviewed-by: None <None>
2021-09-28Copy ignore-2.12.txt to ignore-2.13.txt (#214)Andrew Klychkov
Copy ignore-2.12.txt to ignore-2.13.txt SUMMARY Relates to ansible-collections/overview#45 (comment) Reviewed-by: None <None>
2021-09-20Add support for IPv6 `address_group` and `network_group` (#202)Shawn Wilsher
Add support for IPv6 `address_group` and `network_group` SUMMARY This adds support for ipv6 in network and address groups by adding an afi parameter, but defaulting it to ipv4 for backwards compatibility. Fixes #137. ISSUE TYPE Feature Pull Request COMPONENT NAME vyos_firewall_global Reviewed-by: GomathiselviS <None> Reviewed-by: Shawn Wilsher <None> Reviewed-by: None <None>
2021-09-20Fix `vyos.vyos.vyos_firewall_rules` `state: replaced` to match documentation ↵Shawn Wilsher
(#203) Fix `vyos.vyos.vyos_firewall_rules` `state: replaced` to match documentation SUMMARY vyos.vyos.vyos_firewall_rules should only try to change listed firewall rules, as documented, when the state is set to replaced. As currently implemented (prior to this PR), it better matches what overridden is meant to do. Fixes #201 ISSUE TYPE Bugfix Pull Request COMPONENT NAME vyos.vyos.vyos_firewall_rules ADDITIONAL INFORMATION Cleanup and document existing code for clarity Add a failing idempotent test Add a failing change test Fix failing tests Add change fragment Reviewed-by: GomathiselviS <None> Reviewed-by: Shawn Wilsher <None> Reviewed-by: None <None>
2021-09-09Allow_duplicates for prepare_vyos_tests (#212)Paul Belanger
Allow_duplicates for prepare_vyos_tests Signed-off-by: Paul Belanger pabelanger@redhat.com Reviewed-by: None <None>
2021-08-27IPV6 ICMP type name in vyos.vyos.vyos_firewall_rules is not idempotent (#187)YVarshitha
IPV6 ICMP type name in vyos.vyos.vyos_firewall_rules is not idempotent SUMMARY fix issue: #170 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <None> Reviewed-by: None <None>
2021-08-26Fix pylint sanity issues (#204)GomathiselviS
Fix pylint sanity issues Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com> Reviewed-by: None <None>
2021-08-11Drop ansible_become for testing (#199)Paul Belanger
Drop ansible_become for testing We don't actually need escalated permissions to run these things. Signed-off-by: Paul Belanger pabelanger@redhat.com Reviewed-by: GomathiselviS <None> Reviewed-by: Nathaniel Case <this.is@nathanielca.se> Reviewed-by: None <None>
2021-07-24vyos logging_global resource module (#177)Sagar Paul
vyos logging_global resource module SUMMARY Logging resource module vyos_logging_global ISSUE TYPE New Module Pull Request COMPONENT NAME vyos_logging_global Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
2021-07-07fix issue in route-maps facts code when route-maps facts are empty. (#182)Ashwini Mhatre
fix issue in route-maps facts code when route-maps facts are empty. SUMMARY fixes: #181 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
2021-07-05VyOS Prefix Lists Resource Module Added (#178)Priyam Sahoo
VyOS Prefix Lists Resource Module Added SUMMARY PR for vyos_prefix_lists rm resolves: #99 ISSUE TYPE New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com> Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com> Reviewed-by: Priyam Sahoo <None>
2021-06-22static route fixes (#165)Björn Hemfjäll
static route fixes Reviewed-by: https://github.com/apps/ansible-zuul
2021-06-22Spelling glitch fix on doc (#168)Sagar Paul
Spelling glitch fix on doc Reviewed-by: https://github.com/apps/ansible-zuul
2021-06-14Fix keyerror in firewall_rules when state=overridden (#172)GomathiselviS
Fix keyerror in firewall_rules when state=overridden Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-17linters fix (#160)GomathiselviS
Replace admin_distance with distance while generating static_routes nexthop command Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-17fix route-map delete integrataion test (#162)Ashwini Mhatre
fix route-map delete integrataion test Reviewed-by: https://github.com/apps/ansible-zuul
2021-05-11Vyos route maps (#156)Ashwini Mhatre
Vyos route maps Reviewed-by: https://github.com/apps/ansible-zuul
2021-04-29[firewall_global] port-groups are not added (#143)Shawn Wilsher
[firewall_global] port-groups are not added Reviewed-by: https://github.com/apps/ansible-zuul
2021-04-28VyOS: available_network_resources implemented in vyos_facts (#148)Rohit Thakur
VyOS: available_network_resources implemented in vyos_facts Reviewed-by: https://github.com/apps/ansible-zuul
2021-04-22VYOS: Mask sensitive key values from module result (#151)GomathiselviS
VYOS: Mask sensitive key values from module result Reviewed-by: https://github.com/apps/ansible-zuul
2021-04-14Add ignore.txt for 2.12 (#147)Andrew Klychkov
Add ignore.txt for 2.12 Reviewed-by: https://github.com/apps/ansible-zuul
2021-03-31Get `ansible-test` further along (#142)Shawn Wilsher
Get `ansible-test` further along Reviewed-by: https://github.com/apps/ansible-zuul