diff options
| author | Shawn Wilsher <656602+sdwilsh@users.noreply.github.com> | 2021-09-20 16:25:42 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-20 23:25:42 +0000 |
| commit | 9e829e1b75996b6b8268ab29b105d5dfa97da441 (patch) | |
| tree | b5aed43186cf0481928ac6afcf78c73a77b69bcc /changelogs | |
| parent | 2c13b39aee89cf39eaad64b0775fd387a5599399 (diff) | |
| download | vyos-ansible-old-9e829e1b75996b6b8268ab29b105d5dfa97da441.tar.gz vyos-ansible-old-9e829e1b75996b6b8268ab29b105d5dfa97da441.zip | |
Fix `vyos.vyos.vyos_firewall_rules` `state: replaced` to match documentation (#203)
Fix `vyos.vyos.vyos_firewall_rules` `state: replaced` to match documentation
SUMMARY
vyos.vyos.vyos_firewall_rules should only try to change listed firewall rules, as documented, when the state is set to replaced. As currently implemented (prior to this PR), it better matches what overridden is meant to do.
Fixes #201
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
vyos.vyos.vyos_firewall_rules
ADDITIONAL INFORMATION
Cleanup and document existing code for clarity
Add a failing idempotent test
Add a failing change test
Fix failing tests
Add change fragment
Reviewed-by: GomathiselviS <None>
Reviewed-by: Shawn Wilsher <None>
Reviewed-by: None <None>
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/fragments/fix-firewall_rules-state-replaced.yaml | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/changelogs/fragments/fix-firewall_rules-state-replaced.yaml b/changelogs/fragments/fix-firewall_rules-state-replaced.yaml new file mode 100644 index 0000000..231cd71 --- /dev/null +++ b/changelogs/fragments/fix-firewall_rules-state-replaced.yaml @@ -0,0 +1,3 @@ +--- +bugfixes: + - Fix vyos_firewall_rules with state replaced to only replace the specified rules. |