diff options
| author | Oleksandr Kuchmystyi <o.kuchmystyi@vyos.io> | 2025-07-22 13:05:38 +0300 |
|---|---|---|
| committer | Oleksandr Kuchmystyi <o.kuchmystyi@vyos.io> | 2025-07-22 13:05:38 +0300 |
| commit | 71ade9dce3bfbf9dd8e608eb43ad47896c2045a5 (patch) | |
| tree | 10a551bc2665f67f8dd252fc3931886c83f96099 | |
| parent | 28147b458689b338a25b5bb17d650956c6f37745 (diff) | |
| download | vyos-build-71ade9dce3bfbf9dd8e608eb43ad47896c2045a5.tar.gz vyos-build-71ade9dce3bfbf9dd8e608eb43ad47896c2045a5.zip | |
T7576: Remove unnecessary code for checking dirty build status
```
vyos@r15:~$ show version | match dir
Build commit ID: d8038ded37fadb-dirty
```
Having uncommited files in vyos-build is completely normal:
custom configs, EULA files in official release builds,
anything else that flavor files may include.
However, many people are not familiar with the specific
meaning of "dirty" in git or with the build process and assume
that "dirty" means something went wrong with the image build.
| -rwxr-xr-x | scripts/image-build/build-vyos-image | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/scripts/image-build/build-vyos-image b/scripts/image-build/build-vyos-image index 3275c5de..6919b003 100755 --- a/scripts/image-build/build-vyos-image +++ b/scripts/image-build/build-vyos-image @@ -409,9 +409,6 @@ if __name__ == "__main__": repo = git.Repo('.', search_parent_directories=True) # Retrieve the Git commit ID of the repository, 14 charaters will be sufficient build_git = repo.head.object.hexsha[:14] - # If somone played around with the source tree and the build is "dirty", mark it - if repo.is_dirty(): - build_git += "-dirty" # Retrieve git branch name or current tag # Building a tagged release might leave us checking out a git tag that is not the tip of a named branch (detached HEAD) |