Reorganize unit test locations under tests/unittests (#1126)

This attempts to standardize unit test file location under test/unittests/
such that any source file located at cloudinit/path/to/file.py may have a
corresponding unit test file at test/unittests/path/to/test_file.py.

Noteworthy Comments:
====================
Four different duplicate test files existed:
test_{gpg,util,cc_mounts,cc_resolv_conf}.py
Each of these duplicate file pairs has been merged together. This is a
break in git history for these files.

The test suite appears to have a dependency on test order. Changing test
order causes some tests to fail. This should be rectified, but for now
some tests have been modified in
tests/unittests/config/test_set_passwords.py.

A helper class name starts with "Test" which causes pytest to try
executing it as a test case, which then throws warnings "due to Class
having __init__()".  Silence by changing the name of the class.

# helpers.py is imported in many test files, import paths change
cloudinit/tests/helpers.py -> tests/unittests/helpers.py

# Move directories:
cloudinit/distros/tests -> tests/unittests/distros
cloudinit/cmd/devel/tests -> tests/unittests/cmd/devel
cloudinit/cmd/tests -> tests/unittests/cmd/
cloudinit/sources/helpers/tests -> tests/unittests/sources/helpers
cloudinit/sources/tests -> tests/unittests/sources
cloudinit/net/tests -> tests/unittests/net
cloudinit/config/tests -> tests/unittests/config
cloudinit/analyze/tests/ -> tests/unittests/analyze/

# Standardize tests already in tests/unittests/
test_datasource -> sources
test_distros -> distros
test_vmware -> sources/vmware
test_handler -> config        # this contains cloudconfig module tests
test_runs -> runs

1 files changed, 0 insertions, 68 deletions

diff --git a/tests/unittests/test_distros/test_photon.py b/tests/unittests/test_distros/test_photon.py
deleted file mode 100644
index 1c3145ca..00000000
--- a/tests/unittests/test_distros/test_photon.py
+++ /dev/null
@@ -1,68 +0,0 @@
-# This file is part of cloud-init. See LICENSE file for license information.
-
-from . import _get_distro
-from cloudinit import util
-from cloudinit.tests.helpers import mock
-from cloudinit.tests.helpers import CiTestCase
-
-SYSTEM_INFO = {
-    'paths': {
-        'cloud_dir': '/var/lib/cloud/',
-        'templates_dir': '/etc/cloud/templates/',
-    },
-    'network': {'renderers': 'networkd'},
-}
-
-
-class TestPhoton(CiTestCase):
-    with_logs = True
-    distro = _get_distro('photon', SYSTEM_INFO)
-    expected_log_line = 'Rely on PhotonOS default network config'
-
-    def test_network_renderer(self):
-        self.assertEqual(self.distro._cfg['network']['renderers'], 'networkd')
-
-    def test_get_distro(self):
-        self.assertEqual(self.distro.osfamily, 'photon')
-
-    @mock.patch("cloudinit.distros.photon.subp.subp")
-    def test_write_hostname(self, m_subp):
-        hostname = 'myhostname'
-        hostfile = self.tmp_path('previous-hostname')
-        self.distro._write_hostname(hostname, hostfile)
-        self.assertEqual(hostname, util.load_file(hostfile))
-
-        ret = self.distro._read_hostname(hostfile)
-        self.assertEqual(ret, hostname)
-
-        m_subp.return_value = (None, None)
-        hostfile += 'hostfile'
-        self.distro._write_hostname(hostname, hostfile)
-
-        m_subp.return_value = (hostname, None)
-        ret = self.distro._read_hostname(hostfile)
-        self.assertEqual(ret, hostname)
-
-        self.logs.truncate(0)
-        m_subp.return_value = (None, 'bla')
-        self.distro._write_hostname(hostname, None)
-        self.assertIn('Error while setting hostname', self.logs.getvalue())
-
-    @mock.patch('cloudinit.net.generate_fallback_config')
-    def test_fallback_netcfg(self, m_fallback_cfg):
-
-        key = 'disable_fallback_netcfg'
-        # Don't use fallback if no setting given
-        self.logs.truncate(0)
-        assert(self.distro.generate_fallback_config() is None)
-        self.assertIn(self.expected_log_line, self.logs.getvalue())
-
-        self.logs.truncate(0)
-        self.distro._cfg[key] = True
-        assert(self.distro.generate_fallback_config() is None)
-        self.assertIn(self.expected_log_line, self.logs.getvalue())
-
-        self.logs.truncate(0)
-        self.distro._cfg[key] = False
-        assert(self.distro.generate_fallback_config() is not None)
-        self.assertNotIn(self.expected_log_line, self.logs.getvalue())