diff options
| -rw-r--r-- | cloudinit/distros/__init__.py | 38 | ||||
| -rw-r--r-- | cloudinit/sources/DataSourceAltCloud.py | 2 | ||||
| -rw-r--r-- | cloudinit/util.py | 3 | ||||
| -rw-r--r-- | tests/unittests/test_runs/test_simple_run.py | 6 | ||||
| -rwxr-xr-x | tools/hacking.py | 4 | 
5 files changed, 27 insertions, 26 deletions
diff --git a/cloudinit/distros/__init__.py b/cloudinit/distros/__init__.py index 8a98e334..d2cb0a8b 100644 --- a/cloudinit/distros/__init__.py +++ b/cloudinit/distros/__init__.py @@ -187,23 +187,23 @@ class Distro(object):          # inputs. If something goes wrong, we can end up with a system          # that nobody can login to.          adduser_opts = { -            "gecos": '--comment', -            "homedir": '--home', -            "primary_group": '--gid', -            "groups": '--groups', -            "passwd": '--password', -            "shell": '--shell', -            "expiredate": '--expiredate', -            "inactive": '--inactive', -            "selinux_user": '--selinux-user', -        } +                "gecos": '--comment', +                "homedir": '--home', +                "primary_group": '--gid', +                "groups": '--groups', +                "passwd": '--password', +                "shell": '--shell', +                "expiredate": '--expiredate', +                "inactive": '--inactive', +                "selinux_user": '--selinux-user', +                }          adduser_opts_flags = { -            "no_user_group": '--no-user-group', -            "system": '--system', -            "no_log_init": '--no-log-init', -            "no_create_home": "-M", -        } +                "no_user_group": '--no-user-group', +                "system": '--system', +                "no_log_init": '--no-log-init', +                "no_create_home": "-M", +                }          # Now check the value and create the command          for option in kwargs: @@ -320,9 +320,11 @@ class Distro(object):                  raise e          util.ensure_dir(path, 0750) -    def write_sudo_rules(self, user, rules, sudo_file=None): -        if not sudo_file: -            sudo_file = "/etc/sudoers.d/90-cloud-init-users" +    def write_sudo_rules(self, +        user, +        rules, +        sudo_file="/etc/sudoers.d/90-cloud-init-users", +        ):          content_header = "# user rules for %s" % user          content = "%s\n%s %s\n\n" % (content_header, user, rules) diff --git a/cloudinit/sources/DataSourceAltCloud.py b/cloudinit/sources/DataSourceAltCloud.py index 9812bdcb..d7e1204f 100644 --- a/cloudinit/sources/DataSourceAltCloud.py +++ b/cloudinit/sources/DataSourceAltCloud.py @@ -47,7 +47,7 @@ META_DATA_NOT_SUPPORTED = {      'instance-id': 455,      'local-hostname': 'localhost',      'placement': {}, -} +    }  def read_user_data_callback(mount_dir): diff --git a/cloudinit/util.py b/cloudinit/util.py index 4f5b15ee..7890a3d6 100644 --- a/cloudinit/util.py +++ b/cloudinit/util.py @@ -1193,7 +1193,8 @@ def yaml_dumps(obj):                      indent=4,                      explicit_start=True,                      explicit_end=True, -                    default_flow_style=False) +                    default_flow_style=False, +                    )      return formatted diff --git a/tests/unittests/test_runs/test_simple_run.py b/tests/unittests/test_runs/test_simple_run.py index 60ef812a..22d6cf2c 100644 --- a/tests/unittests/test_runs/test_simple_run.py +++ b/tests/unittests/test_runs/test_simple_run.py @@ -37,13 +37,11 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):          self.replicateTestRoot('simple_ubuntu', new_root)          cfg = {              'datasource_list': ['None'], -            'write_files': [ -                { +            'write_files': [{                      'path': '/etc/blah.ini',                      'content': 'blah',                      'permissions': 0755, -                }, -            ], +            }],              'cloud_init_modules': ['write-files'],          }          cloud_cfg = util.yaml_dumps(cfg) diff --git a/tools/hacking.py b/tools/hacking.py index 26a07c53..11163df3 100755 --- a/tools/hacking.py +++ b/tools/hacking.py @@ -66,8 +66,8 @@ def cloud_import_alphabetical(physical_line, line_number, lines):      # handle import x      # use .lower since capitalization shouldn't dictate order      split_line = import_normalize(physical_line.strip()).lower().split() -    split_previous = import_normalize(lines[line_number - 2]) -    split_previous = split_previous.strip().lower().split() +    split_previous = import_normalize(lines[line_number - 2] +            ).strip().lower().split()      # with or without "as y"      length = [2, 4]      if (len(split_line) in length and len(split_previous) in length and  | 
