diff options
| author | Yuriy Andamasov <yuriy@vyos.io> | 2026-05-10 23:07:12 +0300 |
|---|---|---|
| committer | Yuriy Andamasov <yuriy@vyos.io> | 2026-05-10 23:07:12 +0300 |
| commit | a22df7d89dc52a2af1cff35e6eaba2084ecd0696 (patch) | |
| tree | 46b9bd77604dd44b67e37b6f297381485f202f02 /docs/_ext | |
| parent | 610b2a4d9b00226460d5de5c9a513681a63d61a9 (diff) | |
| download | vyos-documentation-a22df7d89dc52a2af1cff35e6eaba2084ecd0696.tar.gz vyos-documentation-a22df7d89dc52a2af1cff35e6eaba2084ecd0696.zip | |
fix(ci): prepare on GitHub-hosted ubuntu + PR comment on skip
Two more Copilot findings on b0fdd07:
1. line 35 — defense in depth: prepare on self-hosted is risky.
Even though the prepare job doesn't execute fork code (it only does
git diff / git show / file reads — never pip install, npm install,
build, or tests), Copilot's right that running fork content on a
self-hosted runner with internal-network access is the wrong
default. A future maintainer who innocently adds a "run linter"
step to prepare could turn it into an attack vector against the
VyOS internal network or a persistence mechanism on the host.
Moved prepare to runs-on: ubuntu-latest. GitHub-hosted runners are
ephemeral, isolated, and have no path to internal services. The
trusted validate job stays on [self-hosted, web]; the split-job
artifact bridges the trust boundary as before.
Side benefit: removes the runner-side dependency on jq/gh/git
for the prepare job (those are pre-installed on ubuntu-latest).
2. line 149 — skip-notice discoverability.
When secrets are missing the workflow only emits ::notice:: in
the run logs. Contributors checking the PR timeline have no
reason to click through to the run page. Added a new step that
posts an actual PR comment via gh pr comment when skip=true,
running with GH_TOKEN: ${{ github.token }} (the validate job
already has pull-requests: write).
The ::notice:: annotation is preserved alongside.
🤖 Generated by [robots](https://vyos.io)
Diffstat (limited to 'docs/_ext')
0 files changed, 0 insertions, 0 deletions
