diff options
| -rw-r--r-- | CLAUDE.md | 17 |
1 files changed, 17 insertions, 0 deletions
@@ -184,3 +184,20 @@ A PR that both adds and removes TODOs is not contradictory; intent matters. - **Sphinx build** — runs on Read the Docs for every PR; preview URL appears as a check. - **CLA check** — contributors must sign the VyOS CLA before merge. - **Conflict check** — fails the PR if it doesn't merge cleanly into base. + +## PR review workflow + +Two automated reviewers run on PRs in this repo: + +- **Copilot** (`@copilot`) — opt-in, works on draft PRs. Trigger by commenting `@copilot review` on the PR. +- **CodeRabbit** (`@coderabbitai`) — auto-runs when a PR flips to ready-for-review. Does **not** review drafts. Re-trigger with `@coderabbitai review` after each round of fixes. + +Convention: + +1. Open the PR as a **draft** (`gh pr create --draft`). +2. Iterate while draft: comment `@copilot review` per round of commits until Copilot is silent. +3. Flip to ready (`gh pr ready <num>`). CodeRabbit picks it up automatically. +4. Address CodeRabbit threads, push commits, re-comment `@coderabbitai review` if you want another pass. +5. When both bots are silent, the PR is ready for human review. + +Every review thread (Copilot or CodeRabbit) needs an **explicit reply** before resolving — fix in code with the commit SHA, or push back with technical reasoning. Never silently resolve. |