common comments incorporated

Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>

4 files changed, 6 insertions, 34 deletions

diff --git a/plugins/modules/vyos_lldp_global.py b/plugins/modules/vyos_lldp_global.py
index 80ec4c1..3a93c95 100644
--- a/plugins/modules/vyos_lldp_global.py
+++ b/plugins/modules/vyos_lldp_global.py
@@ -30,16 +30,13 @@ from __future__ import absolute_import, division, print_function
 
 __metaclass__ = type
 
-ANSIBLE_METADATA = {
-    "metadata_version": "1.1",
-    "status": ["preview"],
-    "supported_by": "network",
-}
+ANSIBLE_METADATA = {"metadata_version": "1.1", "supported_by": "Ansible"}
 
 DOCUMENTATION = """module: vyos_lldp_global
 short_description: LLDP global resource module
 description: This module manages link layer discovery protocol (LLDP) attributes on
   VyOS devices.
+version_added: "1.0.0"
 notes:
 - Tested against VyOS 1.1.8 (helium).
 - This module works with connection C(network_cli). See L(the VyOS OS Platform Options,../network/user_guide/platform_vyos.html).
@@ -80,7 +77,6 @@ options:
         it into Ansible structured data as per the resource module's argspec and the value is then
         returned in the I(parsed) key within the result.
     type: str
-    version_added: "1.0.0"
   state:
     description:
     - The state of the configuration after module completion.
diff --git a/tests/integration/targets/vyos_lldp_global/tests/cli/gathered.yaml b/tests/integration/targets/vyos_lldp_global/tests/cli/gathered.yaml
index 8ba7dd5..95e01de 100644
--- a/tests/integration/targets/vyos_lldp_global/tests/cli/gathered.yaml
+++ b/tests/integration/targets/vyos_lldp_global/tests/cli/gathered.yaml
@@ -9,9 +9,9 @@
 
 - block:
 
-    - name: Merge the provided configuration with the exisiting running configuration
+    - name: Gather the provided configuration with the exisiting running configuration
       register: result
-      vyos.vyos.vyos_lldp_global: &id001
+      vyos.vyos.vyos_lldp_global:
         config:
         state: gathered
 
@@ -20,14 +20,6 @@
         that:
           - "{{ populate  == result['gathered'] }}"
 
-    - name: Gather the existing running configuration (IDEMPOTENT)
-      register: result
-      vyos.vyos.vyos_lldp_global: *id001
-
-    - name: Assert that the previous task was idempotent
-      assert:
-        that:
-          - result['changed'] == false
   always:
 
     - include_tasks: _remove_config.yaml
diff --git a/tests/integration/targets/vyos_lldp_global/tests/cli/parsed.yaml b/tests/integration/targets/vyos_lldp_global/tests/cli/parsed.yaml
index 21b9324..173e3a6 100644
--- a/tests/integration/targets/vyos_lldp_global/tests/cli/parsed.yaml
+++ b/tests/integration/targets/vyos_lldp_global/tests/cli/parsed.yaml
@@ -19,7 +19,7 @@
 
     - name: Provide the running configuration for parsing (config to be parsed)
       register: result
-      vyos.vyos.vyos_lldp_global: &id001
+      vyos.vyos.vyos_lldp_global:
         running_config: "{{ lookup('file', '_parsed_config.cfg') }}"
         state: parsed
 
@@ -28,14 +28,6 @@
         that: "{{ ansible_facts['network_resources']['lldp_global'] == result['parsed']\
           \ }}"
 
-    - name: Gather the existing running configuration (IDEMPOTENT)
-      register: result
-      vyos.vyos.vyos_lldp_global: *id001
-
-    - name: Assert that the previous task was idempotent
-      assert:
-        that:
-          - result['changed'] == false
   always:
 
     - include_tasks: _remove_config.yaml
diff --git a/tests/integration/targets/vyos_lldp_global/tests/cli/rendered.yaml b/tests/integration/targets/vyos_lldp_global/tests/cli/rendered.yaml
index a832787..620fb78 100644
--- a/tests/integration/targets/vyos_lldp_global/tests/cli/rendered.yaml
+++ b/tests/integration/targets/vyos_lldp_global/tests/cli/rendered.yaml
@@ -11,7 +11,7 @@
 
     - name: Structure provided configuration into device specific commands
       register: result
-      vyos.vyos.vyos_lldp_global: &id001
+      vyos.vyos.vyos_lldp_global:
         config:
           address: 192.0.2.17
           enable: true
@@ -25,14 +25,6 @@
           - "{{ rendered['commands'] | symmetric_difference(result['rendered'])\
             \ |length == 0 }}"
 
-    - name: Structure provided configuration into device specific commands (IDEMPOTENT)
-      register: result
-      vyos.vyos.vyos_lldp_global: *id001
-
-    - name: Assert that the previous task was idempotent
-      assert:
-        that:
-          - result['changed'] == false
   always:
 
     - include_tasks: _remove_config.yaml