diff options
| author | Denys Fedoryshchenko <denys.f@collabora.com> | 2026-05-29 08:58:41 +0300 |
|---|---|---|
| committer | Denys Fedoryshchenko <denys.f@collabora.com> | 2026-05-29 08:58:41 +0300 |
| commit | f8dfbeca348d9f4eb794cdf3756a94f2d0acc730 (patch) | |
| tree | 554f46a535a6d16e4be3f2605837a9b79ab7607b | |
| parent | 028e2090389d2b8968dfb30e4d956264718613e5 (diff) | |
| download | accel-ppp-f8dfbeca348d9f4eb794cdf3756a94f2d0acc730.tar.gz accel-ppp-f8dfbeca348d9f4eb794cdf3756a94f2d0acc730.zip | |
Rejecting any PADR lacking a Service-Name tag (RFC 2516 compliance)
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
| -rw-r--r-- | accel-pppd/ctrl/pppoe/pppoe.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/accel-pppd/ctrl/pppoe/pppoe.c b/accel-pppd/ctrl/pppoe/pppoe.c index 93824af5..d543a129 100644 --- a/accel-pppd/ctrl/pppoe/pppoe.c +++ b/accel-pppd/ctrl/pppoe/pppoe.c @@ -1234,6 +1234,12 @@ padr_tags_done: return; } + if (!service_name_tag) { + if (conf_verbose) + log_warn("pppoe: discard PADR packet (no Service-Name tag present)\n"); + return; + } + if (ntohs(ac_cookie_tag->tag_len) != COOKIE_LENGTH) { if (conf_verbose) log_warn("pppoe: discard PADR packet (incorrect AC-Cookie tag length)\n"); |