diff options
| author | Stephen Hemminger <stephen@networkplumber.org> | 2013-03-29 09:14:45 -0700 |
|---|---|---|
| committer | Stephen Hemminger <stephen@networkplumber.org> | 2013-03-29 09:14:45 -0700 |
| commit | 6154dde83cd05e733275db68673392b00ec026a9 (patch) | |
| tree | aa3a92d5a98383dd8273523ab827dd7721b4ea71 | |
| parent | 8c9951348c65c80ff9d8e3a0edfe0c0d7c4f05fe (diff) | |
| download | vyatta-cfg-6154dde83cd05e733275db68673392b00ec026a9.tar.gz vyatta-cfg-6154dde83cd05e733275db68673392b00ec026a9.zip | |
commit_log: fix questionable code
Perlcritc complains:
scripts/vyatta-log-commit.pl: Variable declared in conditional statement at line 40, column 1. Declare variables outside of the condition. (Severity: 5)
| -rw-r--r-- | scripts/vyatta-log-commit.pl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/scripts/vyatta-log-commit.pl b/scripts/vyatta-log-commit.pl index bbf0852..7fa41a3 100644 --- a/scripts/vyatta-log-commit.pl +++ b/scripts/vyatta-log-commit.pl @@ -37,7 +37,8 @@ use POSIX qw(ttyname); # main # my $status = $ENV{'COMMIT_STATUS'}; -my $commit_status = 'Successful' if ($status eq 'SUCCESS'); +my $commit_status; +$commmit_status = 'Successful' if ($status eq 'SUCCESS'); #open log for logging commit details if (defined $commit_status) { my $cur_tty = ttyname(0); |