summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorChristian Poessinger <christian@poessinger.com>2020-04-10 13:28:46 +0200
committerChristian Poessinger <christian@poessinger.com>2020-04-10 13:31:18 +0200
commit927c98f23a6317e2e3565032023d68b753d71037 (patch)
tree771c8ac3d5c3ca09605cb3768fd1b71f0b03f4a9 /src
parentcbfc9156b37127c0c483ac744e7d168ad988419a (diff)
downloadvyos-1x-927c98f23a6317e2e3565032023d68b753d71037.tar.gz
vyos-1x-927c98f23a6317e2e3565032023d68b753d71037.zip
pppoe: T2248: connect-on-demand and vrf are mutually exclusive
As PPP can be used to establish a connection on-demand it manages the Kernel default route. This can not be used when using VRFs which are managed by the ip-up.d and ip-down.d scripts - thus those options are now mutially exclusive. The best fix would be adding support for VRFs into PPP.
Diffstat (limited to 'src')
-rwxr-xr-xsrc/conf_mode/interfaces-pppoe.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/conf_mode/interfaces-pppoe.py b/src/conf_mode/interfaces-pppoe.py
index 5f073dac6..353a5a12c 100755
--- a/src/conf_mode/interfaces-pppoe.py
+++ b/src/conf_mode/interfaces-pppoe.py
@@ -155,6 +155,9 @@ def verify(pppoe):
if vrf_name and vrf_name not in interfaces():
raise ConfigError(f'VRF {vrf_name} does not exist')
+ if pppoe['on_demand'] and pppoe['vrf']:
+ raise ConfigError('On-demand dialing and VRF can not be used at the same time')
+
return None
def generate(pppoe):